You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by edison su <ed...@citrix.com> on 2013/05/08 20:45:10 UTC

Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 


This addresses bug CLOUDSTACK-1907.


Diffs
-----

  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 

Diff: https://reviews.apache.org/r/11012/diff/


Testing
-------

no


Thanks,

edison su


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20334
-----------------------------------------------------------


Commit 63630a412fddc92fdc68dc27e12d2a68dd09f1dd in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=63630a4 ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20437
-----------------------------------------------------------


Commit 738d35a61d12aa4ff11114aef89f546a077e8629 in branch refs/heads/object_store from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20336
-----------------------------------------------------------

Ship it!


Ship It!

- Chip Childers


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20344
-----------------------------------------------------------


Commit 738d35a61d12aa4ff11114aef89f546a077e8629 in branch refs/heads/internallb from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20335
-----------------------------------------------------------


Commit 738d35a61d12aa4ff11114aef89f546a077e8629 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>


Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by Ryan Lei <ry...@gmail.com>.
I'm glad to see this fixed, but there are some other changes in the
supported guest os type as of XCP 1.6 (at least in my XCP 1.6.10).

For example, Windows 8 (32-bit/64-bit), Ubuntu 10.10, 12.04 , Solaris 10
(all experimental).
Maybe it's best to completely go through the list in XCP 1.6.x, instead of
copying the current list and just fix the ones for System VMs.

Thanks!



On Thu, May 9, 2013 at 8:20 AM, ASF Subversion and Git Services <
asfbot@urd.zones.apache.org> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/#review20359
> -----------------------------------------------------------
>
>
> Commit 738d35a61d12aa4ff11114aef89f546a077e8629 in branch
> refs/heads/planner_reserve from Chip Childers <ch...@gmail.com>
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]
>
> CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more
>
>
> - ASF Subversion and Git Services
>
>
> On May 8, 2013, 6:45 p.m., edison su wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11012/
> > -----------------------------------------------------------
> >
> > (Updated May 8, 2013, 6:45 p.m.)
> >
> >
> > Review request for cloudstack and Chip Childers.
> >
> >
> > Description
> > -------
> >
> > Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907,
> >
> >
> > This addresses bug CLOUDSTACK-1907.
> >
> >
> > Diffs
> > -----
> >
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
> a711ec0
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
> 828a827
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
> 0ce91bc
> >
> > Diff: https://reviews.apache.org/r/11012/diff/
> >
> >
> > Testing
> > -------
> >
> > no
> >
> >
> > Thanks,
> >
> > edison su
> >
> >
>
>

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20359
-----------------------------------------------------------


Commit 738d35a61d12aa4ff11114aef89f546a077e8629 in branch refs/heads/planner_reserve from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java a711ec0 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 828a827 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>