[GitHub] [james-project] Arsnael commented on a change in pull request #288: James 3492

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #288:
URL: https://github.com/apache/james-project/pull/288#discussion_r577314046



##########
File path: mailbox/plugin/quota-search-elasticsearch-v7/src/test/java/org/apache/james/quota/search/elasticsearch/v7/ElasticSearchQuotaSearcherTest.java
##########
@@ -26,15 +26,17 @@
 
 import org.apache.james.core.Username;
 import org.apache.james.core.quota.QuotaSizeLimit;
-import org.apache.james.quota.search.Limit;
-import org.apache.james.quota.search.Offset;
-import org.apache.james.quota.search.QuotaQuery;
-import org.apache.james.quota.search.QuotaSearchTestSystem;
-import org.apache.james.quota.search.QuotaSearcherContract;
+import org.apache.james.domainlist.api.DomainListException;
+import org.apache.james.mailbox.MessageManager;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.quota.search.*;
+import org.apache.james.user.api.UsersRepositoryException;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 
 @ExtendWith(ElasticSearchQuotaSearchTestSystemExtension.class)
+@Disabled

Review comment:
       As @mbaechler said, here it's the same I believe, tests should be disabled, not the test class

##########
File path: server/container/metrics/metrics-es-reporter-v7/src/test/java/org/apache/james/metric/es/v7/ES6ReporterTest.java
##########
@@ -20,10 +20,12 @@
 package org.apache.james.metric.es.v7;
 
 import org.apache.james.backends.es.v7.DockerElasticSearch;
+import org.apache.james.util.docker.Images;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 class ES6ReporterTest extends ESReporterContract {

Review comment:
       Throwing a question here: do we really want to keep `ES2ReporterTest` and `ES6ReporterTest` here? What pushed us to keep `ES2ReporterTest` here in the first place? I forgot

##########
File path: mailbox/elasticsearch-v7/src/test/java/org/apache/james/mailbox/elasticsearch/v7/ElasticSearchIntegrationTest.java
##########
@@ -81,12 +83,14 @@ void tearDown() throws IOException {
         client.close();
     }
 
-    @Override
+    @Disabled("JAMES-3492")

Review comment:
       This is not a test, no need to disable it

##########
File path: mailbox/elasticsearch-v7/src/test/java/org/apache/james/mailbox/elasticsearch/v7/ElasticSearchIntegrationTest.java
##########
@@ -81,12 +83,14 @@ void tearDown() throws IOException {
         client.close();
     }
 
-    @Override
+    @Disabled("JAMES-3492")
+	@Override
     protected void await() {
         elasticSearch.awaitForElasticSearch();
     }
 
-    @Override
+    @Disabled("JAMES-3492")

Review comment:
       This is not a test, no need to disable it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org