You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/23 10:34:03 UTC
Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup does
not respect custom service users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13177
https://issues.apache.org/jira/browse/AMBARI-13177
Repository: ambari
Description
-------
Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
Diff: https://reviews.apache.org/r/38620/diff/
Testing
-------
Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
Thanks,
Gautam Borad
Re: Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup
does not respect custom service users
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/#review100200
-----------------------------------------------------------
Ship it!
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py (line 131)
<https://reviews.apache.org/r/38620/#comment157354>
Same comment before regarding space.
Fix it and Ship It.
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py (line 165)
<https://reviews.apache.org/r/38620/#comment157355>
Same comment regarding space.
Fix it and Ship It
- Alejandro Fernandez
On Sept. 23, 2015, 8:42 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38620/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:42 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13177
> https://issues.apache.org/jira/browse/AMBARI-13177
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
>
> Diff: https://reviews.apache.org/r/38620/diff/
>
>
> Testing
> -------
>
> Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
>
>
> ----------------------------------------------------------------------
> Ran 231 tests in 6.794s
>
> OK
> ----------------------------------------------------------------------
> Total run:799
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup
does not respect custom service users
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/#review100409
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Sept. 24, 2015, 6:22 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38620/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 6:22 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13177
> https://issues.apache.org/jira/browse/AMBARI-13177
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
>
> Diff: https://reviews.apache.org/r/38620/diff/
>
>
> Testing
> -------
>
> Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
>
>
> ----------------------------------------------------------------------
> Ran 231 tests in 6.794s
>
> OK
> ----------------------------------------------------------------------
> Total run:799
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup
does not respect custom service users
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 6:22 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Changes
-------
Address review request comments
Bugs: AMBARI-13177
https://issues.apache.org/jira/browse/AMBARI-13177
Repository: ambari
Description
-------
Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
Diff: https://reviews.apache.org/r/38620/diff/
Testing
-------
Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
----------------------------------------------------------------------
Ran 231 tests in 6.794s
OK
----------------------------------------------------------------------
Total run:799
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup
does not respect custom service users
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/#review100194
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py (line 40)
<https://reviews.apache.org/r/38620/#comment157351>
Nit: Can you add spaces between the items like the rows above?
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py (line 54)
<https://reviews.apache.org/r/38620/#comment157352>
Nit: extra space before =
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py (line 95)
<https://reviews.apache.org/r/38620/#comment157353>
Nit: extra space before =. In general can you look at the changes and apply formatting.
- Sumit Mohanty
On Sept. 23, 2015, 8:42 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38620/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:42 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13177
> https://issues.apache.org/jira/browse/AMBARI-13177
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
> ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
>
> Diff: https://reviews.apache.org/r/38620/diff/
>
>
> Testing
> -------
>
> Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
>
>
> ----------------------------------------------------------------------
> Ran 231 tests in 6.794s
>
> OK
> ----------------------------------------------------------------------
> Total run:799
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38620: AMBARI-13177 : For HDP 2.2: Ranger setup
does not respect custom service users
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38620/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 8:42 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13177
https://issues.apache.org/jira/browse/AMBARI-13177
Repository: ambari
Description
-------
Solved the issue by taking the custom user property and saving that property in install.properties for Ranger
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py a675d97
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py d0fea38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 2009b38
ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826b
Diff: https://reviews.apache.org/r/38620/diff/
Testing (updated)
-------
Tested to install Ranger using custom user in HDP 2.2. Also, verified by enabling disabling Ranger plugins on same cluster.
----------------------------------------------------------------------
Ran 231 tests in 6.794s
OK
----------------------------------------------------------------------
Total run:799
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad