svn commit: r722142 - /geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java

[ma...@apache.org]

Author: manugeorge
Date: Mon Dec  1 09:33:37 2008
New Revision: 722142

URL: http://svn.apache.org/viewvc?rev=722142&view=rev
Log:
GERONIMO-4178 Misleading errors during deployment when missing entries in openejb-jar.xml. Captures and throws a DeploymentException if the containerId is not set as the RA is not specified

Modified:
    geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java

Modified: geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java?rev=722142&r1=722141&r2=722142&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java (original)
+++ geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java Mon Dec  1 09:33:37 2008
@@ -883,6 +883,11 @@
             // add a dependency from the module to the ra so we can be assured the mdb
             // container exists when this app is started
             ejbModuleGBeanData.addDependency(resourceAdapterAbstractName);
+            for(MessageDrivenBeanInfo mdbInfo:mdbs.values()){
+                if(mdbInfo != null && mdbInfo.containerId == null){
+                    throw new DeploymentException("No Resource Adapter defined for MDB '" + mdbInfo.ejbName + "'");
+                }
+            }
         }
     }