You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:31 UTC
Review Request 54553: Removed `using namespace` decl from slave
namespace.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54553/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562
src/slave/containerizer/mesos/containerizer.cpp 990da8bc60c3b8e5a158f5e02ab4f21afc679bce
src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
src/slave/slave.cpp c54d33565dd0c1cf50dba2fbb134a6e546ce8614
src/tests/slave_tests.cpp 967c7307b6fc8e9eb4490f51938bdcf286b5e7a6
Diff: https://reviews.apache.org/r/54553/diff/
Testing
-------
`make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
Thanks,
Benjamin Bannier
Re: Review Request 54553: Removed `using namespace` decl from slave
namespace.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54553/#review158679
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54553/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 11:05 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp d200c117579bc1c2d9d24f14bf4da8f650d3f562
> src/slave/containerizer/mesos/containerizer.cpp 990da8bc60c3b8e5a158f5e02ab4f21afc679bce
> src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
> src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
> src/slave/slave.cpp c54d33565dd0c1cf50dba2fbb134a6e546ce8614
> src/tests/slave_tests.cpp 967c7307b6fc8e9eb4490f51938bdcf286b5e7a6
>
> Diff: https://reviews.apache.org/r/54553/diff/
>
>
> Testing
> -------
>
> `make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
>
>
> Thanks,
>
> Benjamin Bannier
>
>