You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geaflow.apache.org by "Loognqiang (via GitHub)" <gi...@apache.org> on 2025/09/12 11:43:33 UTC
[PR] Jdk11 ci support [geaflow]
Loognqiang opened a new pull request, #618:
URL: https://github.com/apache/geaflow/pull/618
### What changes were proposed in this pull request?
<!--Please describe the major changes for this PR-->
### How was this PR tested?
- [ x] Tests have Added for the changes
- [ ] Production environment verified
#601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "qingwen220 (via GitHub)" <gi...@apache.org>.
qingwen220 commented on code in PR #618:
URL: https://github.com/apache/geaflow/pull/618#discussion_r2347773821
##########
geaflow/geaflow-dsl/geaflow-dsl-runtime/pom.xml:
##########
@@ -154,7 +154,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M3</version>
Review Comment:
this version is supposed to be define in the parent pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "Loognqiang (via GitHub)" <gi...@apache.org>.
Loognqiang commented on code in PR #618:
URL: https://github.com/apache/geaflow/pull/618#discussion_r2348485470
##########
.github/workflows/ci-jdk11.yml:
##########
@@ -0,0 +1,68 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+################################################################################
+
+name: Java CI with Maven On JDK 11
+
+on:
+ push:
+ branches: [ "master" ]
+ pull_request:
+ branches: [ "master" ]
+
+env:
+ JAVA_TOOL_OPTIONS: -Xmx4g
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Print available memory
+ run: free -m
+
+ - name: Set time zone
+ run: sudo ln -sf /usr/share/zoneinfo/Asia/Shanghai /etc/localtime
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ java-version: '11'
+ distribution: 'temurin'
+
+ - name: Setup Protoc
+ uses: arduino/setup-protoc@v2
+ with:
+ version: "21.7"
+
+ # Current hive connector is incompatible with jdk11, implement 4.0.0+ hive version in later.
+ - name: Build and Test On JDK 11
+ run: |
+ test_modules="!geaflow/geaflow-dsl/geaflow-dsl-connector/geaflow-dsl-connector-hive,"
+ test_modules+="!geaflow/geaflow-dsl/geaflow-dsl-runtime,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-common,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-client,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-server,"
+ test_modules+="!geaflow/geaflow-examples,"
+ test_modules+="!geaflow/geaflow-deploy/geaflow-assembly,"
+ test_modules+="!geaflow-mcp"
Review Comment:
Following issue #619 , we will refactor the Connector unit tests and dependencies. The examples module will no longer be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "cbqiao (via GitHub)" <gi...@apache.org>.
cbqiao commented on code in PR #618:
URL: https://github.com/apache/geaflow/pull/618#discussion_r2348171261
##########
geaflow/geaflow-common/src/main/java/org/apache/geaflow/common/binary/BinaryOperations.java:
##########
@@ -21,11 +21,10 @@
import java.lang.reflect.Field;
import java.lang.reflect.Method;
-import sun.misc.Unsafe;
public class BinaryOperations {
- private static final Unsafe UNSAFE;
+ private static final sun.misc.Unsafe UNSAFE;
Review Comment:
The sun.misc.Unsafe class was removed in JDK 9. Can the code still run properly on JDK 11?
##########
.github/workflows/ci-jdk11.yml:
##########
@@ -0,0 +1,68 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+################################################################################
+
+name: Java CI with Maven On JDK 11
+
+on:
+ push:
+ branches: [ "master" ]
+ pull_request:
+ branches: [ "master" ]
+
+env:
+ JAVA_TOOL_OPTIONS: -Xmx4g
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Print available memory
+ run: free -m
+
+ - name: Set time zone
+ run: sudo ln -sf /usr/share/zoneinfo/Asia/Shanghai /etc/localtime
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ java-version: '11'
+ distribution: 'temurin'
+
+ - name: Setup Protoc
+ uses: arduino/setup-protoc@v2
+ with:
+ version: "21.7"
+
+ # Current hive connector is incompatible with jdk11, implement 4.0.0+ hive version in later.
+ - name: Build and Test On JDK 11
+ run: |
+ test_modules="!geaflow/geaflow-dsl/geaflow-dsl-connector/geaflow-dsl-connector-hive,"
+ test_modules+="!geaflow/geaflow-dsl/geaflow-dsl-runtime,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-common,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-client,"
+ test_modules+="!geaflow/geaflow-analytics-service/geaflow-analytics-service-server,"
+ test_modules+="!geaflow/geaflow-examples,"
+ test_modules+="!geaflow/geaflow-deploy/geaflow-assembly,"
+ test_modules+="!geaflow-mcp"
Review Comment:
Are all these modules unable to run on JDK 11? Especially the geaflow-examples module, does this mean none of the example cases support running on JDK 11 yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "Loognqiang (via GitHub)" <gi...@apache.org>.
Loognqiang commented on code in PR #618:
URL: https://github.com/apache/geaflow/pull/618#discussion_r2347963179
##########
geaflow/geaflow-dsl/geaflow-dsl-runtime/pom.xml:
##########
@@ -154,7 +154,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M3</version>
Review Comment:
I have addressed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "Loognqiang (via GitHub)" <gi...@apache.org>.
Loognqiang commented on code in PR #618:
URL: https://github.com/apache/geaflow/pull/618#discussion_r2348473732
##########
geaflow/geaflow-common/src/main/java/org/apache/geaflow/common/binary/BinaryOperations.java:
##########
@@ -21,11 +21,10 @@
import java.lang.reflect.Field;
import java.lang.reflect.Method;
-import sun.misc.Unsafe;
public class BinaryOperations {
- private static final Unsafe UNSAFE;
+ private static final sun.misc.Unsafe UNSAFE;
Review Comment:
The sun.misc.Unsafe class is present in JDK 11 but belongs to the jdk.unsupported module. We can allow the current code to run on JDK 11 by adding specific JVM arguments. For JDK 17+ versions, we will directly adopt new standard APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] Jdk11 ci support [geaflow]
Posted by "cbqiao (via GitHub)" <gi...@apache.org>.
cbqiao merged PR #618:
URL: https://github.com/apache/geaflow/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org