You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/05/06 08:16:32 UTC
[GitHub] [nifi] s9514171 opened a new pull request #5060: Parameter Contexts - Show the wrong information of referencing compon…
s9514171 opened a new pull request #5060:
URL: https://github.com/apache/nifi/pull/5060
…ents
`parameterCount` is used to assign parameter's id, so it not should reset to 0 when calling `showParameterContext`
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
#### Description of PR
[https://issues.apache.org/jira/browse/NIFI-8520](https://issues.apache.org/jira/browse/NIFI-8520)
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-833410798
This is fixing the issue I raised in #5048. Thanks @s9514171
Will leave this open for a few days in case @mcgilman @moranr @scottyaslan want to confirm as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-845624179
CI failed, but seems not related to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-845126247
@scottyaslan I have force-push a new commit for this issue.
This commit unset the rows when calling the `resetDialog`
if we do not unset it,
when we close then open the parameter dialog, the `parameterData.addItem(parameter);` will fire the `onSelectedRowsChanged` to show a wrong information
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-847756354
Thanks @scottyaslan. I also open another JIRA [https://github.com/apache/nifi/pull/5097](https://github.com/apache/nifi/pull/5097) for the issue variable count not reset in variable registry dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633759203
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
- parameterCount = 0;
Review comment:
By not resetting this count each time the parameter context table is displayed the count now grows each time the dialog is opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
s9514171 commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r635921165
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
- parameterCount = 0;
Review comment:
@scottyaslan sorry for the late reply, the first fix idea is referenced from variable handling..., but it seems to have the potential issue as you mentioned. maybe we can also fix it too.
I'm reviewing it again, and currently, I find there is a better way to solve it. I'll update later after testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-840733345
reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633713204
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
- parameterCount = 0;
Review comment:
I have tested this and it works as advertised.... but I can't figure out why this works or what the original issue is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#issuecomment-847257611
Thanks @s9514171 I am a +1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5060:
URL: https://github.com/apache/nifi/pull/5060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633713204
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
- parameterCount = 0;
Review comment:
I have tested this and it works as advertised.... but I can't figure out why this works or what the original issue is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r632740807
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
- parameterCount = 0;
Review comment:
This is needed as the count gets reset every time the `#parameter-context-dialog` is opened and this count is used to track the index of any new parameters. Instead of removing this line try calling `resetUsage()` before we reset the `parameterCount = 0;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org