You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Amir Gajst (Jira)" <ji...@apache.org> on 2021/07/01 11:06:00 UTC
[jira] [Commented] (CALCITE-3524) Add methods to RelBuilder to
create RexSubQuery
[ https://issues.apache.org/jira/browse/CALCITE-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372643#comment-17372643 ]
Amir Gajst commented on CALCITE-3524:
-------------------------------------
[~julianhyde], I did originally consider the stack-based approach. I agree that it's more consistent with the general RelBuilder ethos but what bothered me was that it differs from the way {{Relbuilder.filter}} usually works on the upper-most {{RelNode}} in the stack, whereas in this case, the filter will acts on the second {{RelNode}} in the stack using the upper {{RelNode. }}
At the time I decided to go with my current impl' to keep the {{Relbuilder.filter}} only on the upper {{RelNode }}but if you think the stack-based approach is better I'm fine with that too. Just thought it's worth pointing out. What do you think?
> Add methods to RelBuilder to create RexSubQuery
> -----------------------------------------------
>
> Key: CALCITE-3524
> URL: https://issues.apache.org/jira/browse/CALCITE-3524
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Amir Gajst
> Assignee: Julian Hyde
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.28.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> When building relational expressions, the simplest way is by using the RelBuilder which does not currently support creation of a RexSubQuery.
> We can add RexSubQuery creation functions to the RelBuilder to make it more "visible" and convenient to use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)