[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #93: feat: remove the total filed from query conditions

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876701775


##########
src/views/dashboard/related/trace/Filter.vue:
##########
@@ -100,8 +110,8 @@ const selectorStore = useSelectorStore();
 const dashboardStore = useDashboardStore();
 const traceStore = useTraceStore();
 const traceId = ref<string>("");
-const minTraceDuration = ref<string>("");
-const maxTraceDuration = ref<string>("");
+const minTraceDuration = ref<number>(NaN);
+const maxTraceDuration = ref<number>(NaN);

Review Comment:
   Is this for the duration query bug fix? If so, update the change log when sync to the main repo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org