You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/18 17:07:50 UTC
[GitHub] [trafficcontrol] ericholguin opened a new pull request, #6971: Minor GHA changes
ericholguin opened a new pull request, #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Removes the TO testing and client path from TP integration GHA
Updates the action names to match the other actions, making them shorter.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- GitHub Actions
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923633003
##########
.github/workflows/traffic-ops.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Ops Go client/API integration tests
+name: TO Integration Tests
Review Comment:
Yes, we have clients for the TO API in two other languages: Java and Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
ericholguin commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923643842
##########
.github/workflows/traffic-ops.yml:
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-name: Traffic Ops Go client/API integration tests
+ Traffic Ops Go client/API integration tests
Review Comment:
Oops good catch. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#issuecomment-1187921315
The failure:
```go
--- FAIL: TestServerServerCapabilities (6.10s)
serverservercapability_test.go:612: expected GET Server Server Capabilities with limit = 1 to return first result
serverservercapability_test.go:623: expected GET server server capabilities with limit = 1, offset = 1 to return second result
serverservercapability_test.go:634: expected GET Server Server Capabilities with limit = 1, page = 2 to return second result
FAIL
exit status 1
FAIL github.com/apache/trafficcontrol/traffic_ops/testing/api/v4 272.169s
```
so, merging anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
ericholguin commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923630555
##########
.github/workflows/traffic-ops.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Ops Go client/API integration tests
+name: TO Integration Tests
Review Comment:
Is Go necessary? Do we have another client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923642111
##########
.github/workflows/traffic-ops.yml:
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-name: Traffic Ops Go client/API integration tests
+ Traffic Ops Go client/API integration tests
Review Comment:
The name is on 2 lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923624856
##########
.github/workflows/traffic-ops.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Ops Go client/API integration tests
+name: TO Integration Tests
Review Comment:
The cross-app integration being tested here is TO's API with its Go client. TO is basically just an API, so saying API may be redundant, and it can be abbreviated from Traffic Ops to TO, but imo this should still mention the Go client.
##########
.github/workflows/health-client-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Health Client integration tests
+name: Health Client Integration Tests
Review Comment:
"Traffic Control Health Client" is the name of the app under test in this workflow, so that was actually appropriate - besides casing. The name can be slightly abbreviated to match the executable name: `tc-health-client`.
##########
.github/workflows/cache-config-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Cache Config integration tests
+name: Cache Config Integration Tests
Review Comment:
"Traffic Control Cache Config" is the name of the app being tested, so this was actually appropriate. If the name length bothers you, you could use the abbreviated name "t3c".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman merged PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923626886
##########
.github/workflows/health-client-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Health Client integration tests
+name: Health Client Integration Tests
Review Comment:
Same here, since *Traffic Control* is part of the name of it,
https://github.com/apache/trafficcontrol/blob/eaa6bb89a02be97e4e6e7ceee983bc71ef675214/tc-health-client/README.md#L34
the workflow prob should be labeled *Traffic Control Health Client Integration Tests* or *TC Health Client Integration Tests*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923620456
##########
.github/workflows/cache-config-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Cache Config integration tests
+name: Cache Config Integration Tests
Review Comment:
Since the acronym is T3C (stylized `t3c`), *Traffic Control* should stay in the title IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
ericholguin commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923622352
##########
.github/workflows/cache-config-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Cache Config integration tests
+name: Cache Config Integration Tests
Review Comment:
True. Traffic Control Cache Config Integration Tests or T3C Integration Tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6971: Minor GHA changes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6971:
URL: https://github.com/apache/trafficcontrol/pull/6971#discussion_r923624628
##########
.github/workflows/cache-config-tests.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Traffic Control Cache Config integration tests
+name: Cache Config Integration Tests
Review Comment:
Either would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org