[jira] [Comment Edited] (SLING-7524) Sling Query - unique function does not not remove all duplicates

["Tomek Rękawek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389305#comment-16389305 ] 

Tomek Rękawek edited comment on SLING-7524 at 3/7/18 11:13 AM:
---------------------------------------------------------------

[~jebailey] - I gave it more thought and your arguments seems reasonable. As you wrote, jQuery, Java Stream API, rxjava, etc. - they all have a similar method, so maybe we should have it too.

I merged the PR. Thanks!


was (Author: tomek.rekawek):
[~jebailey] - I gave it more thought and your arguments seems reasonable. As you wrote, jQuery, Java Stream API, rxjava, etc. - they all have a similar method, so maybe we should have it too.

Feel free to merge the PR. Also, please update the Javadoc: it says about the "adjacent" repeating elements. I think it's also worth mentioning that it stores all the processed elements.

Thanks!

> Sling Query - unique function does not not remove all duplicates
> ----------------------------------------------------------------
>
>                 Key: SLING-7524
>                 URL: https://issues.apache.org/jira/browse/SLING-7524
>             Project: Sling
>          Issue Type: Improvement
>          Components: Sling Query
>            Reporter: Jason E Bailey
>            Assignee: Jason E Bailey
>            Priority: Major
>
> the function for unique does not match the contract a unique function usually provides including JQuery, rather it's providing a sequential deduplicator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)