You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zzzxl1993 (via GitHub)" <gi...@apache.org> on 2026/01/15 15:05:21 UTC
[PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
zzzxl1993 opened a new pull request, #59940:
URL: https://github.com/apache/doris/pull/59940
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755671576
# BE UT Coverage Report
Increment line coverage `100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/48b44d8bf8ab8da3544f4c974bfd1f1498fcb827_48b44d8bf8ab8da3544f4c974bfd1f1498fcb827/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/48b44d8bf8ab8da3544f4c974bfd1f1498fcb827_48b44d8bf8ab8da3544f4c974bfd1f1498fcb827/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.00% (18998/35846) |
| Line Coverage | 39.01% (175881/450827) |
| Region Coverage | 33.62% (136287/405401) |
| Branch Coverage | 34.64% (58883/169994) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755671903
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755306526
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755463998
<details>
<summary>TPC-DS: <b>Total hot run time: 173915 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 48b44d8bf8ab8da3544f4c974bfd1f1498fcb827, data reload: false
query5 4426 624 492 492
query6 337 228 211 211
query7 4217 461 248 248
query8 340 268 239 239
query9 8704 2826 2881 2826
query10 513 394 315 315
query11 15255 15029 15103 15029
query12 171 112 112 112
query13 1242 473 372 372
query14 6194 2986 2762 2762
query14_1 2924 2619 2644 2619
query15 213 189 174 174
query16 1014 494 467 467
query17 1110 680 575 575
query18 2524 425 333 333
query19 213 215 191 191
query20 122 115 112 112
query21 212 135 115 115
query22 3917 4248 3806 3806
query23 16080 15669 15355 15355
query23_1 15446 15495 15321 15321
query24 7120 1533 1158 1158
query24_1 1163 1175 1157 1157
query25 510 432 395 395
query26 1253 269 146 146
query27 2779 442 272 272
query28 4566 2125 2116 2116
query29 769 514 431 431
query30 314 237 205 205
query31 796 625 582 582
query32 93 78 73 73
query33 538 359 328 328
query34 908 878 536 536
query35 737 771 683 683
query36 893 893 835 835
query37 141 107 88 88
query38 2729 2716 2617 2617
query39 773 743 746 743
query39_1 690 746 708 708
query40 227 142 124 124
query41 91 82 68 68
query42 107 105 111 105
query43 458 468 406 406
query44 1365 742 735 735
query45 189 188 185 185
query46 835 951 579 579
query47 1438 1510 1361 1361
query48 324 333 243 243
query49 618 452 366 366
query50 633 273 225 225
query51 3843 3829 3872 3829
query52 102 108 101 101
query53 303 326 273 273
query54 310 306 282 282
query55 86 86 78 78
query56 320 348 322 322
query57 1035 976 955 955
query58 286 270 263 263
query59 2109 2173 2102 2102
query60 349 346 323 323
query61 191 185 181 181
query62 406 364 312 312
query63 305 271 275 271
query64 5063 1382 1058 1058
query65 3844 3765 3632 3632
query66 1445 415 312 312
query67 15638 15597 15363 15363
query68 2769 1073 741 741
query69 453 363 320 320
query70 998 947 959 947
query71 323 304 292 292
query72 5626 3267 3298 3267
query73 606 716 317 317
query74 8714 8743 8604 8604
query75 2760 2784 2462 2462
query76 2376 1074 671 671
query77 358 378 310 310
query78 9727 10016 9305 9305
query79 1511 919 585 585
query80 1330 573 477 477
query81 555 264 241 241
query82 995 148 111 111
query83 337 262 235 235
query84 245 120 103 103
query85 1025 497 458 458
query86 415 321 279 279
query87 2895 2820 2696 2696
query88 3540 2600 2560 2560
query89 394 349 327 327
query90 1911 172 167 167
query91 175 163 136 136
query92 83 78 67 67
query93 1167 890 520 520
query94 635 320 295 295
query95 593 409 314 314
query96 652 514 230 230
query97 2371 2399 2281 2281
query98 215 203 201 201
query99 596 595 480 480
Total cold run time: 249373 ms
Total hot run time: 173915 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3757766776
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #59940:
URL: https://github.com/apache/doris/pull/59940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755486117
<details>
<summary>ClickBench: <b>Total hot run time: 26.72 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 48b44d8bf8ab8da3544f4c974bfd1f1498fcb827, data reload: false
query1 0.05 0.04 0.05
query2 0.09 0.05 0.04
query3 0.25 0.08 0.08
query4 1.60 0.11 0.10
query5 0.28 0.25 0.24
query6 1.15 0.66 0.66
query7 0.04 0.03 0.03
query8 0.06 0.04 0.04
query9 0.56 0.50 0.50
query10 0.54 0.53 0.54
query11 0.14 0.10 0.09
query12 0.15 0.11 0.11
query13 0.61 0.59 0.58
query14 0.93 0.95 0.94
query15 0.80 0.79 0.78
query16 0.40 0.40 0.41
query17 1.06 1.05 1.00
query18 0.23 0.22 0.21
query19 1.99 1.87 1.79
query20 0.02 0.01 0.02
query21 15.44 0.25 0.13
query22 5.46 0.06 0.04
query23 15.85 0.28 0.10
query24 0.93 0.43 0.20
query25 0.11 0.06 0.07
query26 0.15 0.13 0.13
query27 0.08 0.06 0.05
query28 3.10 1.11 0.89
query29 12.56 4.00 3.21
query30 0.28 0.14 0.11
query31 2.82 0.63 0.40
query32 3.25 0.55 0.45
query33 3.08 3.06 3.02
query34 15.91 5.06 4.45
query35 4.47 4.49 4.46
query36 0.67 0.51 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.03
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.04 0.03
query42 0.05 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 95.68 s
Total hot run time: 26.72 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755970673
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59940_48b44d8bf8ab8da3544f4c974bfd1f1498fcb827_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59940_48b44d8bf8ab8da3544f4c974bfd1f1498fcb827_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.21% (25364/35123) |
| Line Coverage | 59.00% (265656/450232) |
| Region Coverage | 53.89% (220889/409901) |
| Branch Coverage | 55.52% (94811/170755) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "zzzxl1993 (via GitHub)" <gi...@apache.org>.
zzzxl1993 commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755307700
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755412536
<details>
<summary>TPC-H: <b>Total hot run time: 32321 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 48b44d8bf8ab8da3544f4c974bfd1f1498fcb827, data reload: false
------ Round 1 ----------------------------------
q1 17590 5251 4102 4102
q2 2062 384 258 258
q3 10084 1285 728 728
q4 10218 899 304 304
q5 7514 2110 1833 1833
q6 194 181 141 141
q7 949 789 656 656
q8 9288 1430 1157 1157
q9 4931 4643 4524 4524
q10 6744 1823 1417 1417
q11 502 300 287 287
q12 692 728 574 574
q13 17777 3833 3128 3128
q14 318 304 284 284
q15 566 515 510 510
q16 686 664 655 655
q17 650 786 546 546
q18 6650 6616 7071 6616
q19 1399 1045 669 669
q20 429 384 273 273
q21 3316 2700 2622 2622
q22 1180 1083 1037 1037
Total cold run time: 103739 ms
Total hot run time: 32321 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4565 4273 4385 4273
q2 347 432 344 344
q3 2249 2791 2422 2422
q4 1438 1911 1455 1455
q5 4303 4385 4418 4385
q6 214 176 129 129
q7 1949 1903 1756 1756
q8 2687 2508 2392 2392
q9 7218 7069 7264 7069
q10 2494 2797 2273 2273
q11 525 456 460 456
q12 722 792 633 633
q13 3711 3980 3146 3146
q14 276 286 258 258
q15 526 480 476 476
q16 623 665 595 595
q17 1109 1203 1256 1203
q18 7473 7248 7113 7113
q19 880 791 827 791
q20 1889 1954 1838 1838
q21 4528 4263 4105 4105
q22 1056 1040 957 957
Total cold run time: 50782 ms
Total hot run time: 48069 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix PhraseScorer seek duplicate position read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59940:
URL: https://github.com/apache/doris/pull/59940#issuecomment-3755672182
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org