Re: [PR] Fix PostgreSQL proxy timestamp text output adding trailing .0 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #38566:
URL: https://github.com/apache/shardingsphere/pull/38566#issuecomment-4741560324

   Hi @daguimu, thanks again for working on this PostgreSQL protocol issue.
   
   The fix direction looks reasonable because it targets the `Timestamp.toString()` fallback in `PostgreSQLDataRowPacket`, which matches the root cause of #37437. However, this PR is still not ready to merge because the timestamp fractional padding is locale-sensitive, as described in the previous review, and there has been no response or update for a long time after the change request.
   
   Could you please update the PR to make the padding locale-independent, such as by using `Locale.ROOT` or manual ASCII zero-padding, and add the requested regression test for a non-Latin default locale? If there is still no response or update, we may close this PR later to keep the review queue clear.
   
   Thanks again for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org