[jira] [Commented] (DTACLOUD-351) fgcp: serverType for FWs changed to 'firewall' which is not in server type list

["Dies Koper (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DTACLOUD-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482162#comment-13482162 ] 

Dies Koper commented on DTACLOUD-351:
-------------------------------------

about the patch, some background that I'd like you to review in particular:
In fgcp, FWs need to be stopped before they can be destroyed. This could be done when it was listed as an instance, but now that it's not, I need to do it in destroy_firewall.
Stopping the FW takes about 5 min. So I'm executing the (async) stop request first and in a new thread poll till it's stopped and then destroy it, so that from the customer's point of view the request doesn't time out.
Do I need to return a particular http return code (50n Gateway Timeout?) to indicate that the request hasn't been completed yet (after all, this firewall will still appear in the list of firewalls for 5 minutes, even if any operation on it will return an error saying that it is stopping) or is the default http return code fine?
                
> fgcp: serverType for FWs changed to 'firewall' which is not in server type list
> -------------------------------------------------------------------------------
>
>                 Key: DTACLOUD-351
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-351
>             Project: DeltaCloud
>          Issue Type: Bug
>          Components: Server
>         Environment: fgcp
>            Reporter: Dies Koper
>         Attachments: 0001-fgcp-take-fw-out-of-instance-list.patch
>
>
> fgcp API changed: it now returns 'firewall' for FWs, which is not listed in server type list.
> This causes issues for cimi /machines API which cross-references with hardware_profiles output.
> Better to remove FW instances from instance list altogether.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira