[GitHub] stevedlawrence commented on a change in pull request #44: Handle ChoiceGroups correctly in immediatelyEnclosingModelGroup

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #44: Handle ChoiceGroups correctly in immediatelyEnclosingModelGroup
URL: https://github.com/apache/incubator-daffodil/pull/44#discussion_r168789599
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
 ##########
 @@ -230,6 +230,7 @@ trait Term
         Assert.invariant(this.isInstanceOf[Root])
         None
       }
+      case gcgd: GlobalChoiceGroupDef => Some(gcgd.groupRef.asModelGroup)
 
 Review comment:
   I imagine we also need a GlobalSequenceGroupDef for the case where there are nested sequences? Perhaps this can just be GlobalGroupDef, which is the parent class of Sequence and Choice GroupDefs? But actually, that case already exists just a few lines down. Maybe the bug is on that line, and that line should be changed to the ``Some(...)`` that you have here instead of getting the immediately enclosing model group?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services