You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 14:48:50 UTC
[GitHub] [airflow] jyotidhiman0610 opened a new pull request #13745: Upgrade slack to v3
jyotidhiman0610 opened a new pull request #13745:
URL: https://github.com/apache/airflow/pull/13745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-762404216
[The Workflow run](https://github.com/apache/airflow/actions/runs/494116553) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#discussion_r564046477
##########
File path: airflow/providers/slack/ADDITIONAL_INFO.md
##########
@@ -0,0 +1,25 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# Migration Guide
+
+## 2.0.0
+
+We updated the support for `slack_sdk` from ``>=2.0.0,<3.0.0`` to ``>=3.0.0,<4.0.0``. In most cases, this doesn't mean any breaking changes to the DAG files, but if you used this library directly then you have to make the changes.
+For details, see the `Migration Guide` (https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x) for Python Slack SDK.
Review comment:
```suggestion
For details, see [the Migration Guide](https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x) for Python Slack SDK.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13745:
URL: https://github.com/apache/airflow/pull/13745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-762309865
> Importing slack_sdk.* is recommended. You can still use slack.* with deprecation warnings for a while.
https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x
It looks like it will be worth improving the imports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-764294355
Thanks @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#discussion_r563221653
##########
File path: airflow/providers/slack/ADDITIONAL_INFO.md
##########
@@ -0,0 +1,33 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# Migration Guide
+
+## 3.0.0
+
+Reference: https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x
+
+### Use ``AsyncWebClient`` for async options
+
+With v3 upgrade, `WebClient` no longer has `run_async` and `aiohttp` specific options. If you still need the option or other `aiohttp` specific options, use `LegacyWebClient` (slackclient v2 compatible) or `AsyncWebClient`
+
+
+### Include ``aiohttp`` in requirements
+
+`aiohttp` is no longer automatically resolved with `slack_sdk`(earlier `slackclient`). So, if working with `AsyncWebClient`, `AsyncWebhookClient`, and `LegacyWebClient`, it needs separate installation.
Review comment:
```suggestion
## 2.0.0
We updated the support for `sentry_sdk` from ``>=2.0.0,<3.0.0`` to ``>=3.0.0,<4.0.0``. In most cases, this doesn't mean any breaking changes to the DAG files, but if you used this library directly then you have to make the changes. For details, see the `Migration Guide
<https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x>`__ for Python Slack SDK.
```
We should only focus on the changes that affect our project. In this case, there aren't too many breaking changes except that sometimes users may have conflicting dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-765421929
@jyotidhiman0610 airflow doesn't support async, so you just need to add an entry in ADDITIONAL_INFO.md. if someone wants to, they can install it additionally, but we don't need to install it automatically, because we don't use it. For example, see: https://github.com/apache/airflow/blob/master/airflow/providers/google/ADDITIONAL_INFO.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-762661212
- Taking a look at the failing test.
- Also, verifying _("aiohttp")_ options(might also need some _direction_ here):
> WebClient no longer has run_async and aiohttp specific options. If you still need the option or other aiohttp specific options, use LegacyWebClient (slackclient v2 compatible) or AsyncWebClient
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13745:
URL: https://github.com/apache/airflow/pull/13745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-764028066
I pushed a fix for CI problem. "CI Build / Verify Prod Image Py3.6" job was red.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-764294355
Thanks @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-766849240
[The Workflow run](https://github.com/apache/airflow/actions/runs/509497418) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-765184141
@mik-laj can you please help me with the following:
> WebClient no longer has run_async and aiohttp specific options. If you still need the option or other aiohttp specific options, use LegacyWebClient (slackclient v2 compatible) or AsyncWebClient
What I understand is
- I need to include `aiohttp` in requirements.txt(conf.py) for it to install as it is not normally resolved now
- To enable `aiohttp.Formdata` option, should I add `AsyncWebClient` too in the `SlackHook`?
https://github.com/apache/airflow/blob/94d3ed61d60b134d649a4e9785b2d9c2a88cff05/airflow/providers/slack/hooks/slack.py#L97
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#discussion_r564046477
##########
File path: airflow/providers/slack/ADDITIONAL_INFO.md
##########
@@ -0,0 +1,25 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# Migration Guide
+
+## 2.0.0
+
+We updated the support for `slack_sdk` from ``>=2.0.0,<3.0.0`` to ``>=3.0.0,<4.0.0``. In most cases, this doesn't mean any breaking changes to the DAG files, but if you used this library directly then you have to make the changes.
+For details, see the `Migration Guide` (https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x) for Python Slack SDK.
Review comment:
```suggestion
For details, see [the Migration Guide](https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x) for Python Slack SDK.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-764028066
I pushed a fix for CI problem. "CI Build / Verify Prod Image Py3.6" job was red.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-766849240
[The Workflow run](https://github.com/apache/airflow/actions/runs/509497418) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #13745: Upgrade slack to v3
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13745:
URL: https://github.com/apache/airflow/pull/13745#issuecomment-765499491
@mik-laj added additional information, can you please review the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org