You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/11/13 15:16:25 UTC

[tomcat] branch master updated: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63916

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
     new 4f38e7f  Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63916
4f38e7f is described below

commit 4f38e7f8201401083985a30d45db271b543dae41
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Nov 13 15:16:11 2019 +0000

    Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63916
---
 test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java b/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
index f93b277..0ac987c 100644
--- a/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
+++ b/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
@@ -326,7 +326,10 @@ public class TestNonBlockingAPI extends TomcatBaseTest {
         String servletName = NBWriteServlet.class.getName();
         Tomcat.addServlet(ctx, servletName, servlet);
         ctx.addServletMappingDecoded("/", servletName);
-        tomcat.getConnector().setProperty("socket.txBufSize", "1024");
+        // Note: Low values of socket.txBufSize can trigger very poor
+        //       performance. Set it just low enough to ensure that the
+        //       non-blocking write servlet will see isReady() == false
+        tomcat.getConnector().setProperty("socket.txBufSize", "1048576");
         tomcat.start();
 
         SocketFactory factory = SocketFactory.getDefault();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org