Re: [PR] Implement ordering in segment state transitions [pinot]

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r2002038117


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -927,6 +927,8 @@ private void createNewSegmentZKMetadata(TableConfig tableConfig, StreamConfig st
       newSegmentZKMetadata.setPartitionMetadata(partitionMetadata);
     }
 
+    newSegmentZKMetadata.setPreviousSegment(committingSegmentDescriptor.getSegmentName());

Review Comment:
   Could this be `null`? We should probably check if `committingSegmentZKMetadata == null`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org