[jira] [Commented] (GEODE-165) Add build support for generating antlr classes from grammar

["Avinash Dongre (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754075#comment-15754075 ] 

Avinash Dongre commented on GEODE-165:
--------------------------------------

I made the changes and branch can be found here https://github.com/davinash/geode/tree/feature/GEODE-165

But I am getting spotlessJavaCheck error for the generated files.  ( OQLLexer, OQLParser, OQLLexerTokenTypes )

Do you know a ways to ignore these files from generated-src directory for spotless in gradle.

CC [~mbretl] [~upthewaterspout] [~amb]

> Add build support for generating antlr classes from grammar
> -----------------------------------------------------------
>
>                 Key: GEODE-165
>                 URL: https://issues.apache.org/jira/browse/GEODE-165
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>            Reporter: Dan Smith
>            Assignee: Mark Bretl
>
> The OQL engine currently uses antlr to generate some parsing classes from 
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/oql.g
> These are the generated classes. They are currently checked into the source.
> OQLLexer.java
> OQLLexerTokenTypes.java
> OQLLexerTokenTypes.txt
> OQLParser.java
> They can be generated manually by running antlr.Tool on the provided grammar.
> cd gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/
> java -cp antlr.jar antlr.Tool oql.g
> We should add support to the gradle build to generate these classes.
> In my opinion we should also remove the checked in classes. With gradle we can configure things so that the gradle eclipse target will generate these classes and make them available to the IDE as well. Look at gemfire-core/build.gradle for how we do this with the version properties file:
> sourceSets {
>   main {
>     output.dir(generatedResources, builtBy: 'createVersionPropertiesFile')
>   }
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)