You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Phil Steitz (JIRA)" <ji...@apache.org> on 2006/06/21 20:21:31 UTC

[jira] Commented: (DBCP-175) [dbcp] I'd like to run init SQL after JDBC Connection creation in Tomcat DBCP

    [ http://issues.apache.org/jira/browse/DBCP-175?page=comments#action_12417153 ] 

Phil Steitz commented on DBCP-175:
----------------------------------

This looks good to me.   I am +1 for this change and see no problems with the implementation.   I would prefer to hold off on adding it until 1.3, however, as, while backward compatible, it represents an API change.   

> [dbcp] I'd like to run init SQL after JDBC Connection creation in Tomcat DBCP
> -----------------------------------------------------------------------------
>
>          Key: DBCP-175
>          URL: http://issues.apache.org/jira/browse/DBCP-175
>      Project: Commons Dbcp
>         Type: Improvement

>     Versions: 1.2 Final
>  Environment: Operating System: other
> Platform: Other
>     Reporter: Jiri Melichna
>     Priority: Minor
>  Attachments: DBCP-175-1.txt, DBCP-175-2.txt, DBCP-175-2.txt, dbcp_add_init_sql.zip
>
> Hi!
> I'm porting some j2ee web based applications from BEA Web Logic to Tomcat 5.5. 
> In BEA Web Lobic connection pool it is possible to specify init SQL qurery 
> that server runs after connection is created (before first use). It's very 
> good for example of national settings in Oracle. For correct czech sorting i 
> have to run "setting query":
> ALTER SESSION SET NLS_SORT = XCZECH
> First time i tryed to write interceptor into my application. This interceptor 
> runs ALTER SESSION SET NLS_SORT = XCZECH before evey sorted query (SELECT ... 
> ORDER BY...), but i had some performance problems. So i starded to work with 
> DBCP. I was very wandered about DBCP packages in Tomcat 5.5 and i did not find 
> sources of naming-factory-dbcp.jar. So i refactored, enhanced and compiled 
> full DBCP (with pool and collections). Now i'm a little afraid of some library 
> conflicts (full DBCP, full Pool and full Collections refactored into tomcat 
> packages), but performance is OK and basic tests of my application seems good.
> I added property connectionInitSql for int SQL into BasicDataSource. I had to 
> mofify BasicDataSourceFactory for correct setting of this property. Property 
> is used in method createConnection() of DriverConnectionFactory to init 
> Connection. 
> It would be very nice if you will add this init feature into Tomcat DBCP.
> Best regards
> Jiri Melichna

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org