You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/25 15:17:33 UTC
[GitHub] [incubator-dolphinscheduler] BoYiZhang opened a new pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
BoYiZhang opened a new pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989
Enhance user experience, add close button to file details page
this close #3988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
BoYiZhang commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716387066
> Please solve sonar
Only changed the web code, not the Java code
So there is no coverage on new code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang closed pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
BoYiZhang closed pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716235820
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
ct/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3989&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3989&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3989&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3989&metric=new_duplicated_lines_density&view=list) [0.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3989&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716250605
Please solve sonar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716397361
> > Please solve sonar
>
> Only changed the web code, not the Java code
>
> So there is no coverage on new code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
BoYiZhang commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716165900
Only changed the web page, not the Java code
Why are the following errors reported?
------------------------------
Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project dolphinscheduler-server: There are test failures.
Error:
Error: Please refer to /home/runner/work/incubator-dolphinscheduler/incubator-dolphinscheduler/dolphinscheduler-server/target/surefire-reports for the individual test results.
Error: Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :dolphinscheduler-server
Error: Process completed with exit code 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716235667
> Only changed the web page, not the Java code
>
> Why are the following errors reported?
>
> Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project dolphinscheduler-server: There are test failures.
> Error:
> Error: Please refer to /home/runner/work/incubator-dolphinscheduler/incubator-dolphinscheduler/dolphinscheduler-server/target/surefire-reports for the individual test results.
> Error: Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please read the following articles:
> Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error:
> Error: After correcting the problems, you can resume the build with the command
> Error: mvn -rf :dolphinscheduler-server
> Error: Process completed with exit code 1.
This is not your problem, I will fix it.I have helped you rerun UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 edited a comment on pull request #3989: [Feature-3988][UI] Enhance user experience, add close button to file details page
Posted by GitBox <gi...@apache.org>.
break60 edited a comment on pull request #3989:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3989#issuecomment-716397361
> > Please solve sonar
>
> Only changed the web code, not the Java code
>
> So there is no coverage on new code
Seems to be a problem with this file？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org