You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/28 16:18:55 UTC

[GitHub] [beam] chamikaramj commented on a diff in pull request #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

chamikaramj commented on code in PR #17319:
URL: https://github.com/apache/beam/pull/17319#discussion_r861084554


##########
sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py:
##########
@@ -75,8 +75,8 @@ def build_write_pipeline(self, pipeline):
         pipeline
         | 'Generate' >> beam.Create(range(NUM_RECORDS))  # pylint: disable=bad-option-value
         | 'MakeKV' >> beam.Map(lambda x:
-                               (b'', str(x).encode())).with_output_types(
-                                   typing.Tuple[bytes, bytes])
+                               (None, str(x).encode())).with_output_types(

Review Comment:
   Could we also add a version that uses a non-null non-empty key ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org