[GitHub] [spark] cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on
URL: https://github.com/apache/spark/pull/23880#discussion_r264304709
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -736,7 +741,6 @@ qualifiedName
 
 identifier
     : strictIdentifier
-    | {ansi}? ansiReserved
 
 Review comment:
   This is the only code change I expect. What's the rationale of the other changes? I think `select current_date()` should not be supported in ansi mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org