[GitHub] [airflow] josh-fell commented on a diff in pull request #29502: Validate Hive Beeline parameters

["josh-fell (via GitHub)" <gi...@apache.org>]

josh-fell commented on code in PR #29502:
URL: https://github.com/apache/airflow/pull/29502#discussion_r1105183688


##########
airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -141,6 +141,7 @@ def _prepare_cli_cmd(self) -> list[Any]:
 
         if self.use_beeline:
             hive_bin = "beeline"
+            self._validate_beeline_parameters(conn)

Review Comment:
   Would it make sense to push this validation to the constructor? The Connection object is retrieved there as well as determining the `use_beeline` attr. Could fail faster before even executing the task. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org