You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2018/06/04 23:02:07 UTC
Re: Review Request 67438: RANGER-2108: Ensure that resource names in
service
definition contain only lowercase, hyphens or underscore characters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67438/#review204286
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
Line 594 (original), 609 (patched)
<https://reviews.apache.org/r/67438/#comment286699>
Would be better to update error message from SERVICE_DEF_VALIDATION_ERR_NOT_LOWERCASE_NAME.
- Velmurugan Periasamy
On June 4, 2018, 6:59 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67438/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 6:59 p.m.)
>
>
> Review request for ranger, Ramesh Mani and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2108
> https://issues.apache.org/jira/browse/RANGER-2108
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This is an update to an earlier commit (https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=268512adc3170bb7799c29e3c5aa064750b9e9e7) for the same issue. There may be existing service-defs which have mixed case access-type names, and resource-names containing hyphens/underscore characters. This patch handles such cases.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java 3f9315a7e
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java bdac64019
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java 1fafb12fb
>
>
> Diff: https://reviews.apache.org/r/67438/diff/1/
>
>
> Testing
> -------
>
> Updated unit test cases, ran all unit tests successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>