You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2020/11/24 18:59:25 UTC
Review Request 73038: Entity Creation: Update to Business Metadata
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73038/
-----------------------------------------------------------
Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
Bugs: ATLAS-4048
https://issues.apache.org/jira/browse/ATLAS-4048
Repository: atlas
Description
-------
Please see bug description.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 7cf77ea04
Diff: https://reviews.apache.org/r/73038/diff/1/
Testing
-------
**Functional tests**
Via REST APIs.
Via Import APIs.
**Pre-commit**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/218/
Thanks,
Ashutosh Mestry
Re: Review Request 73038: Entity Creation: Update to Business Metadata
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73038/#review222234
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 25, 2020, 1:30 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73038/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2020, 1:30 a.m.)
>
>
> Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
>
>
> Bugs: ATLAS-4048
> https://issues.apache.org/jira/browse/ATLAS-4048
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Please see bug description.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 7cf77ea04
>
>
> Diff: https://reviews.apache.org/r/73038/diff/2/
>
>
> Testing
> -------
>
> **Functional tests**
> Via REST APIs.
> Via Import APIs.
>
> **Pre-commit**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/218/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 73038: Entity Creation: Update to Business Metadata
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73038/
-----------------------------------------------------------
(Updated Nov. 25, 2020, 1:30 a.m.)
Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-4048
https://issues.apache.org/jira/browse/ATLAS-4048
Repository: atlas
Description
-------
Please see bug description.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 7cf77ea04
Diff: https://reviews.apache.org/r/73038/diff/2/
Changes: https://reviews.apache.org/r/73038/diff/1-2/
Testing
-------
**Functional tests**
Via REST APIs.
Via Import APIs.
**Pre-commit**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/218/
Thanks,
Ashutosh Mestry
Re: Review Request 73038: Entity Creation: Update to Business Metadata
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73038/#review222233
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Lines 1211 (patched)
<https://reviews.apache.org/r/73038/#comment311276>
the last condition, MapUtils.isNotEmpty(entity.getBusinessAttributes(), should be removed. When this is empty, business metadata attributes, if any assigned to the entity, should be deleted.
- Madhan Neethiraj
On Nov. 24, 2020, 6:59 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73038/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2020, 6:59 p.m.)
>
>
> Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
>
>
> Bugs: ATLAS-4048
> https://issues.apache.org/jira/browse/ATLAS-4048
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Please see bug description.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 7cf77ea04
>
>
> Diff: https://reviews.apache.org/r/73038/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> Via REST APIs.
> Via Import APIs.
>
> **Pre-commit**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/218/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>