You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "betodealmeida (via GitHub)" <gi...@apache.org> on 2023/03/30 16:45:52 UTC
[GitHub] [superset] betodealmeida commented on a diff in pull request #23536: chore: allow logs to show error levels for ssh tunnel
betodealmeida commented on code in PR #23536:
URL: https://github.com/apache/superset/pull/23536#discussion_r1153526070
##########
superset/extensions/ssh.py:
##########
@@ -53,8 +53,9 @@ def create_tunnel(
params = {
"ssh_address_or_host": (ssh_tunnel.server_address, ssh_tunnel.server_port),
"ssh_username": ssh_tunnel.username,
- "remote_bind_address": (url.host, url.port), # bind_port, bind_host
+ "remote_bind_address": (url.host, url.port),
"local_bind_address": (self.local_bind_address,),
+ "debug_level": "ERROR",
Review Comment:
I think it's better to set this to the current log level of Superset, so that in production this is `ERROR`, but in dev this is `DEBUG` or `INFO`, eg.
You should be able to get the current log level with something like:
```python
logging.getLogger("flask_appbuilder").level
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org