You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2026/01/06 22:41:20 UTC

[Impala-ASF-CR] IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events

Hello Quanlong Huang, Pranav Lodha, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21665

to look at the new patch set (#23).

Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events
......................................................................

IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events

When enable_reload_events is true, catalogd fires RELOAD events after
REFRESH finishes reloading the table/partition. The RELOAD event id is
also used to update lastRefreshEventId of the table/partition. This is
problematic when enable_skipping_older_events is true. HMS events
generated after the reload and before the RELOAD event will be skipped.

Solution:
Fetch the current HMS notification event id before the table/partition
is refreshed, and set it as lastRefreshEventId on the metadata object.

Testing:
- Manually verified the issue is addressed.
- Added an end-to-end test which is close to real time issue.

Change-Id: I90039da77ec561c5aede44456f88c6650582815b
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/DebugUtils.java
M tests/custom_cluster/test_events_custom_configs.py
6 files changed, 104 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/21665/23
-- 
To view, visit http://gerrit.cloudera.org:8080/21665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b
Gerrit-Change-Number: 21665
Gerrit-PatchSet: 23
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>