You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/31 21:06:55 UTC
[GitHub] [incubator-tvm] anijain2305 opened a new pull request #5197: [TOPI
x86] Adding unroll_kw config option for depthwise conv2d.
anijain2305 opened a new pull request #5197: [TOPI x86] Adding unroll_kw config option for depthwise conv2d.
URL: https://github.com/apache/incubator-tvm/pull/5197
@yzhliu
unroll_kw is used for normal conv2d schedules as well. In the case of depthwise conv2d, the input pixels are actually vectorized (not broadcasted as in the case with normal conv2d). This potentially can create opportunities for reusing the data vector across two output pixels. Therefore, adding unroll_kw config option.
In any case, this does not bring perf degradation. It makes search space larger.
Concern - This might require a minor change in Tophub configuration. I can make that change once this PR is merged (or just before).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on issue #5197: [TOPI x86] Adding
unroll_kw config option for depthwise conv2d.
Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #5197: [TOPI x86] Adding unroll_kw config option for depthwise conv2d.
URL: https://github.com/apache/incubator-tvm/pull/5197#issuecomment-608611605
Thanks @anijain2305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu merged pull request #5197: [TOPI x86] Adding
unroll_kw config option for depthwise conv2d.
Posted by GitBox <gi...@apache.org>.
yzhliu merged pull request #5197: [TOPI x86] Adding unroll_kw config option for depthwise conv2d.
URL: https://github.com/apache/incubator-tvm/pull/5197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on issue #5197: [TOPI x86]
Adding unroll_kw config option for depthwise conv2d.
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #5197: [TOPI x86] Adding unroll_kw config option for depthwise conv2d.
URL: https://github.com/apache/incubator-tvm/pull/5197#issuecomment-608610363
I tuned mobilenet v2, I dont see any difference in e2e perf, but I see that some depthwise convs are picking up unroll_kw = True (introduced by this PR). Configs for all the depthwise convs are
~~~
[('tile_ic', [-1, 32]), ('tile_oc', [-1, 32]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,359
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,1217
[('tile_ic', [-1, 16]), ('tile_oc', [-1, 16]), ('tile_ow', [-1, 4]), ('unroll_kw', False)],None,2378
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,1430
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 14]), ('unroll_kw', True)],None,859
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 14]), ('unroll_kw', True)],None,859
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,859
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', True)],None,85
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', True)],None,85
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', True)],None,85
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 1]), ('unroll_kw', True)],None,85
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 14]), ('unroll_kw', True)],None,1433
[('tile_ic', [-1, 8]), ('tile_oc', [-1, 8]), ('tile_ow', [-1, 14]), ('unroll_kw', True)],None,1433
[('tile_ic', [-1, 4]), ('tile_oc', [-1, 4]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,948
[('tile_ic', [-1, 4]), ('tile_oc', [-1, 4]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,1655
[('tile_ic', [-1, 4]), ('tile_oc', [-1, 4]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,1655
[('tile_ic', [-1, 4]), ('tile_oc', [-1, 4]), ('tile_ow', [-1, 1]), ('unroll_kw', False)],None,1655
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on issue #5197: [TOPI x86]
Adding unroll_kw config option for depthwise conv2d.
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #5197: [TOPI x86] Adding unroll_kw config option for depthwise conv2d.
URL: https://github.com/apache/incubator-tvm/pull/5197#issuecomment-607531826
Thanks. I will wait for https://github.com/apache/incubator-tvm/pull/5200 to get merged and re-run with my PR and add the numbers here. Then, we can merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services