You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fangmu <gi...@git.apache.org> on 2015/11/11 08:41:31 UTC

[GitHub] flink pull request: fix pos assignment of instance

GitHub user fangmu opened a pull request:

    https://github.com/apache/flink/pull/1345

    fix pos assignment of instance

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fangmu/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1345
    
----
commit d1c56cdc2eb447be53498976eba9f86062987fc5
Author: qingmeng.wyh <qi...@taobao.com>
Date:   2015-11-11T07:40:19Z

    fix pos assignment of instance

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: fix pos assignment of instance

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1345#issuecomment-155735166
  
    This looks like a bug you fixed. Do you have a case where this bug kicked in that you could add as a test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: fix pos assignment of instance

Posted by fangmu <gi...@git.apache.org>.

Github user fangmu commented on the pull request:

    https://github.com/apache/flink/pull/1345#issuecomment-155810945
  
    I found this when learning codes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: fix pos assignment of instance

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1345#issuecomment-158107692
  
    Will merge this for 1.0.0 and 0.10.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: fix pos assignment of instance

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1345#issuecomment-157783778
  
    Thanks for spotting the error @fangmu. 
    
    I assume that this error never occurred because we rarely start multiple instances on the same host. It is a crucial fix imho and should be part of `0.10.1`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: fix pos assignment of instance

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1345


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---