You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2025/09/22 01:26:47 UTC
[PR] Autosave "Data Transfer Batch Size" in Workflow Settings via debounced valueChanges; [texera]
carloea2 opened a new pull request, #3752:
URL: https://github.com/apache/texera/pull/3752
### Summary
This PR makes **Workflow Settings → Data Transfer Batch Size** persist reliably by wiring the
form control to a debounced `valueChanges` subscription that invokes
`confirmUpdateDataTransferBatchSize(...)`. The previous behavior updated the
FormControl but could fail to propagate/persist unless a manual handler fired.
- Add: `valueChanges` → `map(Number)` → `filter(valid)` → `distinctUntilChanged` → `debounceTime(300)` → `confirmUpdateDataTransferBatchSize(v)`
- Add: `untilDestroyed(this)` to avoid leaks
The current persistence policy remains the same: only persist when the user is logged in.
## Rationale / Problem
Users could change the batch size but see it not persist, because nothing triggered
`setWorkflowDataTransferBatchSize(...)` and `WorkflowPersistService.persistWorkflow(...)`
in a consistent way.
## Behavior (Before → After)
- **Before**: Changing the input updated the form only; persistence was inconsistent.
- **After**: Changing the input updates the workflow settings and triggers persistence
*once* after the user stops typing for 300ms. Reloading the workflow shows the saved value.
## Repro (before this patch)
1. Open a workflow.
2. Go to **Workflow Settings**.
3. Change **Data Transfer Batch Size** and click Left Panel/Versions;
4. Reload Settings: value reverts to default.
## Verification (after this patch)
- Change the value; Go to Versions Tab; Go back to Settings; The new value is persisted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #3752:
URL: https://github.com/apache/texera/pull/3752#issuecomment-3335798836
> @mengw15 Hello, when we talk about this PR you told me something was removed by error in a previous merge, is thar right?, I think the previous solution is clearer and more direct, I could not trace it back, can you?
>
> Thanks.
Yes. I raised a PR about this issue, please check: https://github.com/apache/texera/pull/3770. I think maybe we can close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #3752:
URL: https://github.com/apache/texera/pull/3752#issuecomment-3335788586
@mengw15
Hello, when we talk about this PR you told me something was removed by error in a previous merge, is thar right?, I think the previous solution is clearer and more direct, I could not trace it back, can you?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "Lacia7u7 (via GitHub)" <gi...@apache.org>.
Lacia7u7 commented on PR #3752:
URL: https://github.com/apache/texera/pull/3752#issuecomment-3335806498
Ok got it thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #3752:
URL: https://github.com/apache/texera/pull/3752#issuecomment-3316686803
Thanks for the PR. Please create an issue to describe the problem and a design, then use this PR to address the issue. Try to include screenshots in the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 closed pull request #3752: feat(gui): autosave Data Transfer Batch Size via debounced valueChanges
URL: https://github.com/apache/texera/pull/3752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(gui): autosave Data Transfer Batch Size via debounced valueChanges [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #3752:
URL: https://github.com/apache/texera/pull/3752#issuecomment-3335807734
Ok got it thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org