[GitHub] [spark] srowen commented on a change in pull request #24631: [SPARK-27774][CORE][EXAMPLES][MLLIB] Avoid hardcoded configs

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24631: [SPARK-27774][CORE][EXAMPLES][MLLIB] Avoid hardcoded configs
URL: https://github.com/apache/spark/pull/24631#discussion_r285562259
 
 

 ##########
 File path: examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala
 ##########
 @@ -24,6 +24,7 @@ import org.apache.log4j.{Level, Logger}
 import scopt.OptionParser
 
 import org.apache.spark.{SparkConf, SparkContext}
+import org.apache.spark.internal.config.Kryo._
 
 Review comment:
   Hm, I think we might not want to modify the examples actually. They demonstrate what users might run. But they won't be able to import internal classes like this, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org