You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/26 13:56:25 UTC
[GitHub] [maven-ear-plugin] elharo opened a new pull request #34: update ejb plugin
elharo opened a new pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34
@mabrarov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin
Posted by GitBox <gi...@apache.org>.
mabrarov commented on a change in pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998
##########
File path: pom.xml
##########
@@ -88,7 +88,7 @@
<project.build.outputTimestamp>2020-09-26T20:10:30Z</project.build.outputTimestamp>
<mavenWarPluginVersion>3.3.1</mavenWarPluginVersion>
<mavenCompilerPluginVersion>2.5.1</mavenCompilerPluginVersion>
- <mavenEjbPluginVersion>2.3</mavenEjbPluginVersion>
+ <mavenEjbPluginVersion>3.1.0</mavenEjbPluginVersion>
Review comment:
Refer to [`ejbVersion`](https://maven.apache.org/plugins/maven-ejb-plugin/ejb-mojo.html#ejbVersion) parameter of Maven EJB Plugin. Maven EJB Plugin 2.3 uses [`2.1` as a default value of `ejbProperty`](https://github.com/apache/maven-ejb-plugin/blob/maven-ejb-plugin-2.3/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java#L177) while Maven EJB Plugin 3.1.0 uses `3.1` as a default value. Maybe it's reasonable to review tests where Maven EJB Plugin is used and update (remove or add) `ejbVersion`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin
Posted by GitBox <gi...@apache.org>.
mabrarov commented on a change in pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998
##########
File path: pom.xml
##########
@@ -88,7 +88,7 @@
<project.build.outputTimestamp>2020-09-26T20:10:30Z</project.build.outputTimestamp>
<mavenWarPluginVersion>3.3.1</mavenWarPluginVersion>
<mavenCompilerPluginVersion>2.5.1</mavenCompilerPluginVersion>
- <mavenEjbPluginVersion>2.3</mavenEjbPluginVersion>
+ <mavenEjbPluginVersion>3.1.0</mavenEjbPluginVersion>
Review comment:
Refer to [`ejbVersion`](https://maven.apache.org/plugins/maven-ejb-plugin/ejb-mojo.html#ejbVersion) parameter of Maven EJB Plugin. Maven EJB Plugin 2.3 uses [`2.1` as a default value of `ejbProperty`](https://github.com/apache/maven-ejb-plugin/blob/maven-ejb-plugin-2.3/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java#L177) while Maven EJB Plugin 3.1.0 uses `3.1` as a default value. Maybe it's reasonable to review tests where Maven EJB Plugin is used and update (remove or add) `ejbProperty`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #34: update ejb plugin
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549357981
##########
File path: pom.xml
##########
@@ -88,7 +88,7 @@
<project.build.outputTimestamp>2020-09-26T20:10:30Z</project.build.outputTimestamp>
<mavenWarPluginVersion>3.3.1</mavenWarPluginVersion>
<mavenCompilerPluginVersion>2.5.1</mavenCompilerPluginVersion>
- <mavenEjbPluginVersion>2.3</mavenEjbPluginVersion>
+ <mavenEjbPluginVersion>3.1.0</mavenEjbPluginVersion>
Review comment:
I prefer to leave the tests as is to verify and indicate that nothing was broken by this change. Unless of course something was broken, in which case a changed test shows exactly what changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo merged pull request #34: update ejb plugin
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin
Posted by GitBox <gi...@apache.org>.
mabrarov commented on a change in pull request #34:
URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998
##########
File path: pom.xml
##########
@@ -88,7 +88,7 @@
<project.build.outputTimestamp>2020-09-26T20:10:30Z</project.build.outputTimestamp>
<mavenWarPluginVersion>3.3.1</mavenWarPluginVersion>
<mavenCompilerPluginVersion>2.5.1</mavenCompilerPluginVersion>
- <mavenEjbPluginVersion>2.3</mavenEjbPluginVersion>
+ <mavenEjbPluginVersion>3.1.0</mavenEjbPluginVersion>
Review comment:
Refer to [`ejbVersion`](https://maven.apache.org/plugins/maven-ejb-plugin/ejb-mojo.html#ejbVersion) parameter of Maven EJB Plugin. Maven EJB Plugin 2.3 uses [`2.1` as a default value of `ejbProperty`](https://github.com/apache/maven-ejb-plugin/blob/maven-ejb-plugin-2.3/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java#L177) while Maven EJB Plugin 3.1.0 uses `3.1` as a default value. Maybe it's reasonable to review tests where Maven EJB Plugin is used and update (remove or add) `ejbVersion`.
For example, `ejbVersion` can be removed from [src/test/resources/projects/project-089/ejb/pom.xml](https://github.com/apache/maven-ear-plugin/blob/check/src/test/resources/projects/project-089/ejb/pom.xml#L45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org