You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/09/09 14:53:56 UTC

[GitHub] [hadoop] 9uapaw commented on a change in pull request #3396: YARN-10872. Replace getPropsWithPrefix calls in AutoCreatedQueueTemplate

9uapaw commented on a change in pull request #3396:
URL: https://github.com/apache/hadoop/pull/3396#discussion_r705425384



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ConfigurationProperties.java
##########
@@ -132,7 +132,8 @@ private void copyProperties(
       String prefixToTrim = trimPrefix;
 
       if (!trimPrefix.isEmpty()) {
-        if (!key.equals(trimPrefix)) {
+        if (!key.equals(trimPrefix) &&
+            !trimPrefix.endsWith(CapacitySchedulerConfiguration.DOT)) {

Review comment:
       Could you make a test case for this scenario?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org