You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/10/08 13:38:07 UTC

Review Request 73641: Repair Composite indexes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/1/


Testing
-------

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: Repair Composite indexes

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/#review223593
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On Oct. 8, 2021, 1:38 p.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73641/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2021, 1:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state
> 
> 
> Diffs
> -----
> 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
>   repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
>   repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73641/diff/1/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73641: ATLAS-4447: Update Composite indexes status

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

(Updated Oct. 12, 2021, 8:52 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Changes
-------

rebase


Bugs: ATLAS-4447
    https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs (updated)
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 50d17a223 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java b3eb07142 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/5/

Changes: https://reviews.apache.org/r/73641/diff/4-5/


Testing
-------

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: ATLAS-4447: Update Composite indexes status

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/#review223602
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 11, 2021, 10:30 p.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73641/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2021, 10:30 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4447
>     https://issues.apache.org/jira/browse/ATLAS-4447
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state
> 
> 
> Diffs
> -----
> 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343 
>   repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
>   repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73641/diff/4/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73641: ATLAS-4447: Update Composite indexes status

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

(Updated Oct. 12, 2021, 5:30 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Changes
-------

changed the configuration to set default true


Bugs: ATLAS-4447
    https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs (updated)
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/4/

Changes: https://reviews.apache.org/r/73641/diff/3-4/


Testing
-------

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: ATLAS-4447: Update Composite indexes status

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

(Updated Oct. 11, 2021, 7:20 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Changes
-------

added configuration for the patch
added commit per index


Bugs: ATLAS-4447
    https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs (updated)
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/3/

Changes: https://reviews.apache.org/r/73641/diff/2-3/


Testing
-------

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: Repair Composite indexes

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

(Updated Oct. 11, 2021, 8 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Changes
-------

Addressed review comments


Bugs: ATLAS-4447
    https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs (updated)
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/2/

Changes: https://reviews.apache.org/r/73641/diff/1-2/


Testing
-------

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: Repair Composite indexes

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/#review223595
-----------------------------------------------------------


Fix it, then Ship it!





graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 38 (patched)
<https://reviews.apache.org/r/73641/#comment312702>

    nit: unused import; consider removing



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 324 (patched)
<https://reviews.apache.org/r/73641/#comment312703>

    nit: add import statement for SchemaStatus and SchemaAction.



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 329 (patched)
<https://reviews.apache.org/r/73641/#comment312701>

    Add more detail to log statement:
    
    LOG.info("Index schema status updated for index: {}, from {} to {}.", index.name(), SchemaStatus.REGISTERED, SchemaStatus.ENABLED);



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 332 (patched)
<https://reviews.apache.org/r/73641/#comment312700>

    consider adding else if block to handle WARN logging for "INSTALLED" schema status



repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
Lines 27 (patched)
<https://reviews.apache.org/r/73641/#comment312704>

    consider renaming class to "UpdateCompositeIndexStatusPatch", since this JAVA patch deals with UPDATING the schema status of certain composite indexes.


- Sarath Subramanian


On Oct. 8, 2021, 9:05 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73641/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2021, 9:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4447
>     https://issues.apache.org/jira/browse/ATLAS-4447
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state
> 
> 
> Diffs
> -----
> 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
>   repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
>   repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73641/diff/1/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73641: Repair Composite indexes

Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
-----------------------------------------------------------

(Updated Oct. 8, 2021, 4:05 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.


Bugs: ATLAS-4447
    https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
-------

If by any chance, commposite index are not enabled, this patch fixes the composite index from REGISTERED state to ENABLED state


Diffs
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55 
  repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java d30971afc 
  repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/1/


Testing
-------

manually tested


Thanks,

Pinal Shah