[GitHub] [incubator-uniffle] advancedxy commented on pull request #511: [ISSUE-507] Fix Flaky Test: ShuffleBufferManagerTest#cacheShuffleDataTest

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on PR #511:
URL: https://github.com/apache/incubator-uniffle/pull/511#issuecomment-1407581105

   > So i think the reason is that some threads have not exit after running ShuffleTaskManagerTest#removeShuffleDataWithHdfsTest.
   
   This pr should fix the flaky test. However, I think this statement indicates that there might be other resource leaking problem in the test code as many test create a shuffle server but never stop the server. We should create a new issue to track this problem:  close/stop shuffle server after use in each test case. @xianjingfeng or @zuston(since you wrote most of the related test code) could you help track and resolve this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org