You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/29 00:31:06 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7208: arch/makefile: preprocess link script to make configure more flexibly
xiaoxiang781216 commented on code in PR #7208:
URL: https://github.com/apache/incubator-nuttx/pull/7208#discussion_r982961073
##########
arch/arm/src/Makefile:
##########
@@ -165,7 +166,10 @@ define LINK_ALLSYMS
$(Q) $(call DELFILE, allsyms.tmp allsyms$(OBJEXT))
endef
-nuttx$(EXEEXT): $(HEAD_OBJ) board$(DELIM)libboard$(LIBEXT) $(ARCHSCRIPT)
+$(addsuffix .tmp,$(ARCHSCRIPT)): $(ARCHSCRIPT)
Review Comment:
```suggestion
$(ARCHSCRIPT).tmp: $(ARCHSCRIPT)
```
##########
arch/arm/src/Makefile:
##########
@@ -165,7 +166,10 @@ define LINK_ALLSYMS
$(Q) $(call DELFILE, allsyms.tmp allsyms$(OBJEXT))
endef
-nuttx$(EXEEXT): $(HEAD_OBJ) board$(DELIM)libboard$(LIBEXT) $(ARCHSCRIPT)
+$(addsuffix .tmp,$(ARCHSCRIPT)): $(ARCHSCRIPT)
+ $(call PREPROCESS, $(patsubst %.tmp,%,$@), $@)
+
+nuttx$(EXEEXT): $(HEAD_OBJ) board$(DELIM)libboard$(LIBEXT) $(addsuffix .tmp,$(ARCHSCRIPT))
Review Comment:
```suggestion
nuttx$(EXEEXT): $(HEAD_OBJ) board$(DELIM)libboard$(LIBEXT) $(ARCHSCRIPT).tmp
```
##########
arch/arm/src/Makefile:
##########
@@ -184,6 +188,7 @@ ifneq ($(CONFIG_WINDOWS_NATIVE),y)
grep -v '\(compiled\)\|\(\$(OBJEXT)$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' | \
sort > $(TOPDIR)$(DELIM)System.map
endif
+ $(Q) $(call DELFILE, $(addsuffix .tmp,$(ARCHSCRIPT)))
Review Comment:
```suggestion
$(Q) $(call DELFILE, $(ARCHSCRIPT).tmp)
```
##########
arch/arm/src/Makefile:
##########
@@ -165,7 +166,10 @@ define LINK_ALLSYMS
$(Q) $(call DELFILE, allsyms.tmp allsyms$(OBJEXT))
endef
-nuttx$(EXEEXT): $(HEAD_OBJ) board$(DELIM)libboard$(LIBEXT) $(ARCHSCRIPT)
+$(addsuffix .tmp,$(ARCHSCRIPT)): $(ARCHSCRIPT)
+ $(call PREPROCESS, $(patsubst %.tmp,%,$@), $@)
Review Comment:
```suggestion
$(call PREPROCESS, $<, $@)
```
##########
arch/arm/src/Makefile:
##########
@@ -220,6 +225,7 @@ clean:
ifeq ($(BOARDMAKE),y)
$(Q) $(MAKE) -C board clean
endif
+ $(call DELFILE, $(addsuffix .tmp,$(ARCHSCRIPT)))
Review Comment:
```suggestion
$(call DELFILE,$(ARCHSCRIPT).tmp)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org