You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 03:13:15 UTC

[GitHub] [pulsar] gaozhangmin opened a new pull request, #17500: [improve][admin] Remove duplicate subName encoding

gaozhangmin opened a new pull request, #17500:
URL: https://github.com/apache/pulsar/pull/17500

   
   
   ### Motivation
   In `TopicsImpl`, we encoded subscription name twice.
   
   
   ### Modifications
   Remove `Codec.encode(subName);`, do encoding in `topicPath` method
   
   
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #17500: [improve][admin] Remove duplicate subName encoding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17500:
URL: https://github.com/apache/pulsar/pull/17500#issuecomment-1238877209

   @gaozhangmin Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin closed pull request #17500: [improve][admin] Remove duplicate subName encoding

Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #17500: [improve][admin] Remove duplicate  subName encoding
URL: https://github.com/apache/pulsar/pull/17500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org