[GitHub] [hadoop] steveloughran commented on a diff in pull request #5987: HADOOP-18865 ABFS: Adding "100-continue" in userAgent String if enabled

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5987:
URL: https://github.com/apache/hadoop/pull/5987#discussion_r1305728584


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -751,6 +752,15 @@ public AbfsRestOperation append(final String path, final byte[] buffer,
       }
     }
 
+    // Check if the retry is with "Expect: 100-continue" header being present in the previous request.

Review Comment:
   not sure about this strategy of patching/replacing the ua header



##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -86,6 +86,7 @@ public final class ITestAbfsClient extends AbstractAbfsIntegrationTest {
 
   private static final String ACCOUNT_NAME = "bogusAccountName.dfs.core.windows.net";
   private static final String FS_AZURE_USER_AGENT_PREFIX = "Partner Service";
+  private static final String HUNDRED_CONTINUE_USER_AGENT = SINGLE_WHITE_SPACE + HUNDRED_CONTINUE + SEMICOLON;

Review Comment:
   normally i'd say "use the AbfsClient const", but here we have regression testing that the client constant doesn't diverge from what the server expects, so I`m happy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org