[GitHub] [ratis] hanishakoneru edited a comment on pull request #481: RATIS-1381. Remove MetricsRegistries warning for creating without adding reporters

[GitBox <gi...@apache.org>]

hanishakoneru edited a comment on pull request #481:
URL: https://github.com/apache/ratis/pull/481#issuecomment-860896794


   > I am fine with removing the warning, but can you please give more information how can the problem be reproduced? As far as I remember I also saw it earlier, but today I just tested with ozone sh and ozonen freon and couldn't reproduce.
   
   I was able to see this just be running a {{ozone sh key put}} command. I think we log this warning once for each BlockOutputStream. When creating a large key (multiple blocks), this log message is seen multiple times. 
   
   > Do we have any racecondition somewhere between adding reporters + registering the first metric? Or is the metric registration missing from somewhere?
   
   When creating the RatisMetricRegistry, it is expecting that there should be some reporters registered already. If not, this warning message is thrown. In JVMMetrics, we add consoleReporter and JmxReporter before creating the MetricsRegistry. But in RatisMetrics, this is not done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org