You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by re...@apache.org on 2013/08/04 14:45:43 UTC

svn commit: r1510167 - in /uima/sandbox/uimafit/trunk: uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/ uimafit-maven-plugin/src/main/java/org/apache/uima/fit/...

Author: rec
Date: Sun Aug  4 12:45:43 2013
New Revision: 1510167

URL: http://svn.apache.org/r1510167
Log:
[UIMA-2892] Improve/clean up JavaDoc (and Exceptions)
- Removed unnecessary throws declarations

Modified:
    uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ConfigurationParameterInitializerTest.java
    uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/FSCollectionFactoryTest.java
    uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/JCasUtilTest.java
    uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/LocaleUtilTest.java
    uima/sandbox/uimafit/trunk/uimafit-maven-plugin/src/main/java/org/apache/uima/fit/maven/EnhanceMojo.java

Modified: uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ConfigurationParameterInitializerTest.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ConfigurationParameterInitializerTest.java?rev=1510167&r1=1510166&r2=1510167&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ConfigurationParameterInitializerTest.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/component/initialize/ConfigurationParameterInitializerTest.java Sun Aug  4 12:45:43 2013
@@ -372,7 +372,7 @@ public class ConfigurationParameterIniti
   }
 
   @Test
-  public void testEnumDefaultValue() throws Exception {
+  public void testEnumDefaultValue() {
     try {
       AnalysisEngine aed = AnalysisEngineFactory.createEngine(DefaultEnumValueAE.class,
               (Object[]) null);

Modified: uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/FSCollectionFactoryTest.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/FSCollectionFactoryTest.java?rev=1510167&r1=1510166&r2=1510167&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/FSCollectionFactoryTest.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/FSCollectionFactoryTest.java Sun Aug  4 12:45:43 2013
@@ -79,13 +79,13 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateFSList() throws Exception {
+  public void testCreateFSList() {
     assertEquals(tokens, create(createFSList(jcas, tokens)));
     assertEquals(tokens, create(createFSList(jcas, tokens), Token.class));
   }
 
   @Test
-  public void testCreateFSArray() throws Exception {
+  public void testCreateFSArray() {
     assertEquals(tokenFSs, create(createArrayFS(jcas.getCas(), tokenFSs)));
     assertEquals(
             tokenFSs,
@@ -101,7 +101,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateBooleanArray() throws Exception {
+  public void testCreateBooleanArray() {
     assertEquals(asList(true, false),
             asList(toObject(createBooleanArray(jcas.getCas(), asList(true, false)).toArray())));
     assertEquals(asList(true, false),
@@ -114,7 +114,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateByteArray() throws Exception {
+  public void testCreateByteArray() {
     assertEquals(asList((byte) 0, (byte) 1),
             asList(toObject(createByteArray(jcas.getCas(), asList((byte) 0, (byte) 1)).toArray())));
     assertEquals(asList((byte) 0, (byte) 1),
@@ -126,7 +126,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateDoubleArray() throws Exception {
+  public void testCreateDoubleArray() {
     assertEquals(asList(0.0, 1.0),
             asList(toObject(createDoubleArray(jcas.getCas(), asList(0.0, 1.0)).toArray())));
     assertEquals(asList(0.0, 1.0),
@@ -138,7 +138,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateFloatArray() throws Exception {
+  public void testCreateFloatArray() {
     assertEquals(asList(0.0f, 1.0f),
             asList(toObject(createFloatArray(jcas.getCas(), asList(0.0f, 1.0f)).toArray())));
     assertEquals(asList(0.0f, 1.0f),
@@ -150,12 +150,12 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateFloatList() throws Exception {
+  public void testCreateFloatList() {
     assertEquals(asList(0.0f, 1.0f), create(createFloatList(jcas, asList(0.0f, 1.0f))));
   }
 
   @Test
-  public void testCreateIntArray() throws Exception {
+  public void testCreateIntArray() {
     assertEquals(asList(0, 1), asList(toObject(createIntArray(jcas.getCas(), asList(0, 1))
             .toArray())));
     assertEquals(asList(0, 1), asList(toObject(createIntArray(jcas.getCas(), new int[] { 0, 1 })
@@ -165,12 +165,12 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateIntegerList() throws Exception {
+  public void testCreateIntegerList() {
     assertEquals(asList(0, 1), create(createIntegerList(jcas, asList(0, 1))));
   }
 
   @Test
-  public void testCreateLongArray() throws Exception {
+  public void testCreateLongArray() {
     assertEquals(asList(0l, 1l), asList(toObject(createLongArray(jcas.getCas(), asList(0l, 1l))
             .toArray())));
     assertEquals(asList(0l, 1l),
@@ -181,7 +181,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateShortArray() throws Exception {
+  public void testCreateShortArray() {
     assertEquals(
             asList((short) 0, (short) 1),
             asList(toObject(createShortArray(jcas.getCas(), asList((short) 0, (short) 1)).toArray())));
@@ -194,7 +194,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateStringArray() throws Exception {
+  public void testCreateStringArray() {
     assertEquals(asList("0", "1"), asList(createStringArray(jcas.getCas(), asList("0", "1"))
             .toArray()));
     assertEquals(asList("0", "1"),
@@ -205,7 +205,7 @@ public class FSCollectionFactoryTest {
   }
 
   @Test
-  public void testCreateStringList() throws Exception {
+  public void testCreateStringList() {
     assertEquals(asList("0", "1"), create(createStringList(jcas, asList("0", "1"))));
   }
 }

Modified: uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/JCasUtilTest.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/JCasUtilTest.java?rev=1510167&r1=1510166&r2=1510167&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/JCasUtilTest.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/JCasUtilTest.java Sun Aug  4 12:45:43 2013
@@ -80,7 +80,7 @@ public class JCasUtilTest extends Compon
    * Test Tokens (Stems + Lemmas) overlapping with each other.
    */
   @Test
-  public void testSelectCoveredOverlapping() throws Exception {
+  public void testSelectCoveredOverlapping() {
     add(jCas, 3, 16);
     add(jCas, 37, 61);
     add(jCas, 49, 75);
@@ -99,7 +99,7 @@ public class JCasUtilTest extends Compon
    * Test what happens if there is actually nothing overlapping with the Token.
    */
   @Test
-  public void testSelectCoveredNoOverlap() throws Exception {
+  public void testSelectCoveredNoOverlap() {
     new Sentence(jCas, 3, 31).addToIndexes();
     new Sentence(jCas, 21, 21).addToIndexes();
     new Sentence(jCas, 24, 44).addToIndexes();
@@ -157,7 +157,7 @@ public class JCasUtilTest extends Compon
    * Test what happens if there is actually nothing overlapping with the Token.
    */
   @Test
-  public void testSelectBetweenInclusion() throws Exception {
+  public void testSelectBetweenInclusion() {
     Token t1 = new Token(jCas, 45, 57);
     t1.addToIndexes();
     Token t2 = new Token(jCas, 52, 52);
@@ -224,7 +224,7 @@ public class JCasUtilTest extends Compon
    * Test Tokens (Stems + Lemmas) overlapping with each other.
    */
   @Test
-  public void testSelectCoveringOverlapping() throws Exception {
+  public void testSelectCoveringOverlapping() {
     add(jCas, 3, 16);
     add(jCas, 37, 61);
     add(jCas, 49, 75);

Modified: uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/LocaleUtilTest.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/LocaleUtilTest.java?rev=1510167&r1=1510166&r2=1510167&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/LocaleUtilTest.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit-legacy-support/src/test/java/org/apache/uima/fit/util/LocaleUtilTest.java Sun Aug  4 12:45:43 2013
@@ -34,7 +34,7 @@ import org.junit.Test;
 public class LocaleUtilTest {
 
   @Test
-  public void testGetLocaleConstant() throws Exception {
+  public void testGetLocaleConstant() {
     assertEquals(Locale.US, getLocaleConstant("US"));
     assertNull(getLocaleConstant("UN"));
     assertEquals(Locale.ENGLISH, getLocaleConstant("ENGLISH"));
@@ -44,7 +44,7 @@ public class LocaleUtilTest {
   }
 
   @Test
-  public void testCreateLocale() throws Exception {
+  public void testCreateLocale() {
     assertEquals(new Locale("en", "US"), createLocale("en-US"));
     assertEquals(new Locale("es"), createLocale("es"));
     assertEquals(new Locale("ko", "KR"), createLocale("ko-KR"));

Modified: uima/sandbox/uimafit/trunk/uimafit-maven-plugin/src/main/java/org/apache/uima/fit/maven/EnhanceMojo.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uimafit/trunk/uimafit-maven-plugin/src/main/java/org/apache/uima/fit/maven/EnhanceMojo.java?rev=1510167&r1=1510166&r2=1510167&view=diff
==============================================================================
--- uima/sandbox/uimafit/trunk/uimafit-maven-plugin/src/main/java/org/apache/uima/fit/maven/EnhanceMojo.java (original)
+++ uima/sandbox/uimafit/trunk/uimafit-maven-plugin/src/main/java/org/apache/uima/fit/maven/EnhanceMojo.java Sun Aug  4 12:45:43 2013
@@ -326,7 +326,7 @@ public class EnhanceMojo extends Abstrac
    * Enhance resource meta data
    */
   private void enhanceResourceMetaData(JavaSource aAST, Class<?> aClazz, CtClass aCtClazz,
-          Multimap<String, String> aReportData) throws MojoExecutionException {
+          Multimap<String, String> aReportData) {
     ClassFile classFile = aCtClazz.getClassFile();
     ConstPool constPool = classFile.getConstPool();