[GitHub] [kafka] dajac commented on a diff in pull request #14121: MINOR: Remove onPartitionsLost overriding in favor of default implementation

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277683057


##########
examples/src/main/java/kafka/examples/Consumer.java:
##########
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection<TopicPartition> partitions) {
     public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
         Utils.printOut("Assigned partitions: %s", partitions);
     }
-
-    @Override
-    public void onPartitionsLost(Collection<TopicPartition> partitions) {
-        Utils.printOut("Lost partitions: %s", partitions);

Review Comment:
   I don't really understand the motivation of this change. It seems to me that we are losing the log if we do so. Could you elaborate more on the motivation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org