re： [CI][Code style] Need help with checking code style check by Ali way

[Jave-Chen <ke...@foxmail.com>]

Because there isn't an checkstyle configure file of Ali way, 
 So it is impossible to check code style in with GitHub Action. 
 But I strongly suggest use IDE plugin to check your code 
 locally . 





------------------ 原始邮件 ------------------
发件人:&nbsp;"Jave-Chen"<kejia.chen@foxmail.com&gt;;
发送时间:&nbsp;2020年2月8日(星期六) 晚上9:05
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;

主题:&nbsp;回复： [CI][Code style] Need help with checking code style check by Ali way



The file <https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml&amp;gt; is created at 2017, are u sure?




------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
发件人:&amp;nbsp;"lidong dai"<dailidong66@gmail.com&amp;gt;;
发送时间:&amp;nbsp;2020年2月8日(星期六) 晚上8:59
收件人:&amp;nbsp;"dev"<dev@dolphinscheduler.apache.org&amp;gt;;
抄送:&amp;nbsp;"wangyang.03"<wangyang.03@bytedance.com&amp;gt;;
主题:&amp;nbsp;Re: [CI][Code style] Need help with checking code style check by Ali way



hi ,
I see checkstyle.xml (
https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml)
from
http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E,
is this checkstyle OK ?


<https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml&amp;gt;


Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------


Jave-Chen <kejia.chen@foxmail.com&amp;gt; 于2020年2月8日周六 下午4:41写道：

&amp;gt; Hi, all
&amp;gt; As we discussed about checkstyle, we agreed use Ali code style.
&amp;gt; <
&amp;gt; http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E&amp;amp;gt
&amp;gt; ;
&amp;gt;
&amp;gt;
&amp;gt; I did some effects with this, and there are some problems now:
&amp;gt; 1. I did't find checkstyle config file for Ali code style, which means we
&amp;gt; need to&amp;amp;nbsp;
&amp;gt; create these rules by ourselves.
&amp;gt; 2. Another possible way is to use PMD, but the PMD implementations has
&amp;gt; fewer&amp;amp;nbsp;
&amp;gt; rules than IDEA plugin or Eclipse plugin.&amp;amp;nbsp;
&amp;gt; For example indent check is not implemented by PMD, which I think
&amp;gt; is unacceptable.
&amp;gt; You can see The PDM implementations and rules&amp;amp;nbsp; at
&amp;gt; <https://github.com/alibaba/p3c/tree/master/p3c-pmd&amp;amp;gt;
&amp;gt;
&amp;gt;
&amp;gt; So, is there anyone can help solve these problems？
&amp;gt; Or we have to reconsider Google code style.