You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/12 21:29:42 UTC
[GitHub] [spark] sigmod opened a new pull request #32135: Add condition lambda and rule id to the resolve function family
sigmod opened a new pull request #32135:
URL: https://github.com/apache/spark/pull/32135
…and rule id.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818405128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818377632
**[Test build #137242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137242/testReport)** for PR 32135 at commit [`fc85416`](https://github.com/apache/spark/commit/fc85416b3e73ecbe205350af5ebca2455136c754).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818455415
> @sigmod Thanks for the work!
> I have left a comment in https://issues.apache.org/jira/browse/SPARK-34916?focusedCommentId=17319839&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17319839
> Could you create an umbrella Jira for the framework and related works? Then, we can create a new JIRA for this PR.
Done.
Thanks, Gengliang! I updated the JIRA issue in this PR to subtask SPARK-35043. Let me know if I missed anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309527
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41829/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818287474
**[Test build #137249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137249/testReport)** for PR 32135 at commit [`5a9f68b`](https://github.com/apache/spark/commit/5a9f68bc49bc0fbbdd00463dfb0532630d600beb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818257335
**[Test build #137242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137242/testReport)** for PR 32135 at commit [`fc85416`](https://github.com/apache/spark/commit/fc85416b3e73ecbe205350af5ebca2455136c754).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818433783
**[Test build #137252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137252/testReport)** for PR 32135 at commit [`94597df`](https://github.com/apache/spark/commit/94597df72fbd61c570c2a2d973e149be68ed848e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309536
**[Test build #137252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137252/testReport)** for PR 32135 at commit [`94597df`](https://github.com/apache/spark/commit/94597df72fbd61c570c2a2d973e149be68ed848e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612363798
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -39,6 +39,9 @@ import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.catalyst.streaming.StreamingRelationV2
import org.apache.spark.sql.catalyst.trees.TreeNodeRef
+import org.apache.spark.sql.catalyst.trees.TreePattern.{
Review comment:
It passes..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818402239
**[Test build #137246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137246/testReport)** for PR 32135 at commit [`20860e4`](https://github.com/apache/spark/commit/20860e4e32822f04648dba06b653b7d322511230).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818285483
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818285483
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818451206
**[Test build #137276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137276/testReport)** for PR 32135 at commit [`9db15f0`](https://github.com/apache/spark/commit/9db15f0ee51bca66e5ca66a47fd93506a421f664).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818627577
**[Test build #137276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137276/testReport)** for PR 32135 at commit [`9db15f0`](https://github.com/apache/spark/commit/9db15f0ee51bca66e5ca66a47fd93506a421f664).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818285951
**[Test build #137246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137246/testReport)** for PR 32135 at commit [`20860e4`](https://github.com/apache/spark/commit/20860e4e32822f04648dba06b653b7d322511230).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309527
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41829/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818288825
**[Test build #137250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137250/testReport)** for PR 32135 at commit [`fcf9fe2`](https://github.com/apache/spark/commit/fcf9fe2ce040ef15a4c1f4e7ea90412c5d9ee182).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818257335
**[Test build #137242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137242/testReport)** for PR 32135 at commit [`fc85416`](https://github.com/apache/spark/commit/fc85416b3e73ecbe205350af5ebca2455136c754).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818385895
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818667972
GA passes. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612247231
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -39,6 +39,9 @@ import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.catalyst.streaming.StreamingRelationV2
import org.apache.spark.sql.catalyst.trees.TreeNodeRef
+import org.apache.spark.sql.catalyst.trees.TreePattern.{
Review comment:
Normally we put it all on a single line. If it passes then I am happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818305639
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41826/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818449382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137252/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32135:
URL: https://github.com/apache/spark/pull/32135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818288825
**[Test build #137250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137250/testReport)** for PR 32135 at commit [`fcf9fe2`](https://github.com/apache/spark/commit/fcf9fe2ce040ef15a4c1f4e7ea90412c5d9ee182).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612223850
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala
##########
@@ -104,17 +155,30 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] { self: LogicalPlan =>
/** Similar to [[resolveOperatorsUp]], but does it top-down. */
def resolveOperatorsDown(rule: PartialFunction[LogicalPlan, LogicalPlan]): LogicalPlan = {
- if (!analyzed) {
+ resolveOperatorsDownWithPruning(AlwaysProcess.fn, UnknownRuleId)(rule)
+ }
+
+ /** Similar to [[resolveOperatorsUpWithPruning]], but does it top-down. */
+ def resolveOperatorsDownWithPruning(cond: TreePatternBits => Boolean,
+ ruleId: RuleId = UnknownRuleId)(rule: PartialFunction[LogicalPlan, LogicalPlan])
+ : LogicalPlan = {
+ if (!analyzed && cond.apply(self) && !isRuleIneffective(ruleId)) {
AnalysisHelper.allowInvokingTransformsInAnalyzer {
Review comment:
Yeah, makes sense.
I'll see if I can remove allowInvokingTransformsInAnalyzer in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818279654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818518287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612246989
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala
##########
@@ -104,17 +155,30 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] { self: LogicalPlan =>
/** Similar to [[resolveOperatorsUp]], but does it top-down. */
def resolveOperatorsDown(rule: PartialFunction[LogicalPlan, LogicalPlan]): LogicalPlan = {
- if (!analyzed) {
+ resolveOperatorsDownWithPruning(AlwaysProcess.fn, UnknownRuleId)(rule)
+ }
+
+ /** Similar to [[resolveOperatorsUpWithPruning]], but does it top-down. */
+ def resolveOperatorsDownWithPruning(cond: TreePatternBits => Boolean,
+ ruleId: RuleId = UnknownRuleId)(rule: PartialFunction[LogicalPlan, LogicalPlan])
+ : LogicalPlan = {
+ if (!analyzed && cond.apply(self) && !isRuleIneffective(ruleId)) {
AnalysisHelper.allowInvokingTransformsInAnalyzer {
Review comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #32135: [SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818445025
@hvanhovell @gengliangwang @maryannxue @dbaliafroozeh this PR is ready for review. Let me know if you have any questions. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32135: [SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818449118
@sigmod Thanks for the work!
I have left a comment in https://issues.apache.org/jira/browse/SPARK-34916?focusedCommentId=17319839&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17319839
Could you create an umbrella Jira for the framework and related works? Then, we can create a new JIRA for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818518331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41855/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818632375
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818632375
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818405976
**[Test build #137250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137250/testReport)** for PR 32135 at commit [`fcf9fe2`](https://github.com/apache/spark/commit/fcf9fe2ce040ef15a4c1f4e7ea90412c5d9ee182).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818385895
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137242/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818518331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41855/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612205986
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -39,6 +39,9 @@ import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.catalyst.streaming.StreamingRelationV2
import org.apache.spark.sql.catalyst.trees.TreeNodeRef
+import org.apache.spark.sql.catalyst.trees.TreePattern.{
Review comment:
Does this pass scalastyle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818449382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137252/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612208641
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala
##########
@@ -104,17 +155,30 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] { self: LogicalPlan =>
/** Similar to [[resolveOperatorsUp]], but does it top-down. */
def resolveOperatorsDown(rule: PartialFunction[LogicalPlan, LogicalPlan]): LogicalPlan = {
- if (!analyzed) {
+ resolveOperatorsDownWithPruning(AlwaysProcess.fn, UnknownRuleId)(rule)
+ }
+
+ /** Similar to [[resolveOperatorsUpWithPruning]], but does it top-down. */
+ def resolveOperatorsDownWithPruning(cond: TreePatternBits => Boolean,
+ ruleId: RuleId = UnknownRuleId)(rule: PartialFunction[LogicalPlan, LogicalPlan])
+ : LogicalPlan = {
+ if (!analyzed && cond.apply(self) && !isRuleIneffective(ruleId)) {
AnalysisHelper.allowInvokingTransformsInAnalyzer {
Review comment:
A bit of OCD, but do we really have to do this check for each recursive call? It seems a bit wasteful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818406766
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137250/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818287474
**[Test build #137249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137249/testReport)** for PR 32135 at commit [`5a9f68b`](https://github.com/apache/spark/commit/5a9f68bc49bc0fbbdd00463dfb0532630d600beb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612220546
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -39,6 +39,9 @@ import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.catalyst.streaming.StreamingRelationV2
import org.apache.spark.sql.catalyst.trees.TreeNodeRef
+import org.apache.spark.sql.catalyst.trees.TreePattern.{
Review comment:
It seemed ok -- I didn't see scalastyle complained anything.
But let me know if there's a convention in the Spark codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818285951
**[Test build #137246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137246/testReport)** for PR 32135 at commit [`20860e4`](https://github.com/apache/spark/commit/20860e4e32822f04648dba06b653b7d322511230).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818405129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a change in pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on a change in pull request #32135:
URL: https://github.com/apache/spark/pull/32135#discussion_r612208641
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala
##########
@@ -104,17 +155,30 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] { self: LogicalPlan =>
/** Similar to [[resolveOperatorsUp]], but does it top-down. */
def resolveOperatorsDown(rule: PartialFunction[LogicalPlan, LogicalPlan]): LogicalPlan = {
- if (!analyzed) {
+ resolveOperatorsDownWithPruning(AlwaysProcess.fn, UnknownRuleId)(rule)
+ }
+
+ /** Similar to [[resolveOperatorsUpWithPruning]], but does it top-down. */
+ def resolveOperatorsDownWithPruning(cond: TreePatternBits => Boolean,
+ ruleId: RuleId = UnknownRuleId)(rule: PartialFunction[LogicalPlan, LogicalPlan])
+ : LogicalPlan = {
+ if (!analyzed && cond.apply(self) && !isRuleIneffective(ruleId)) {
AnalysisHelper.allowInvokingTransformsInAnalyzer {
Review comment:
A bit of OCD, but do we really have to do this check for each recursive call? It seems a bit wasteful. We could also just call transformDownWithPruning at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818400489
**[Test build #137249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137249/testReport)** for PR 32135 at commit [`5a9f68b`](https://github.com/apache/spark/commit/5a9f68bc49bc0fbbdd00463dfb0532630d600beb).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32135: [SPARK-35043][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818451206
**[Test build #137276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137276/testReport)** for PR 32135 at commit [`9db15f0`](https://github.com/apache/spark/commit/9db15f0ee51bca66e5ca66a47fd93506a421f664).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818406766
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137250/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32135: [WIP][SPARK-34916][SQL] Add condition lambda and rule id to the resolve function family
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32135:
URL: https://github.com/apache/spark/pull/32135#issuecomment-818309045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org