You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/08/01 07:01:15 UTC
Re: Review Request 24137: allow disabling direct sql per query with external
metastore
> On July 31, 2014, 9:01 p.m., Sergey Shelukhin wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 395
> > <https://reviews.apache.org/r/24137/diff/1/?file=646540#file646540line395>
> >
> > would it be enough to make it package-visible?
It's on IHMSHandler, which is a public interface.
> On July 31, 2014, 9:01 p.m., Sergey Shelukhin wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 270
> > <https://reviews.apache.org/r/24137/diff/1/?file=646540#file646540line270>
> >
> > why are these made static? I see that there can be multiple HMSHandler-s, incl. thru derived classes. Are they always one per thread? If multiple handlers (incl. derived ones), semantics can change
I've been misunderstood till now that the HMSHandler is created per client like hiveservers. Cannot imagine there would be a case that a client is using multiple processors simultaneously but I've understood your point. Will be rolled-back.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24137/#review49290
-----------------------------------------------------------
On July 31, 2014, 1:34 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24137/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 1:34 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7532
> https://issues.apache.org/jira/browse/HIVE-7532
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently with external metastore, direct sql can only be disabled via metastore config globally. Perhaps it makes sense to have the ability to propagate the setting per query from client to override the metastore setting, e.g. if one particular query causes it to fail.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681
> common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java ee98d17
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 9e416b5
> metastore/if/hive_metastore.thrift 55f41db
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 5cc1cd8
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java d26183b
> metastore/src/java/org/apache/hadoop/hive/metastore/IHMSHandler.java 1675751
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 5add436
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java c28c46a
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStoreProxy.java 1cf09d4
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 86172b9
> metastore/src/java/org/apache/hadoop/hive/metastore/events/ConfigChangeEvent.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24137/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>