[GitHub] [beam] steveniemitz commented on a change in pull request #17151: [BEAM-14144] Record JFR profiles when GC thrashing is detected

[GitBox <gi...@apache.org>]

steveniemitz commented on a change in pull request #17151:
URL: https://github.com/apache/beam/pull/17151#discussion_r832456391



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java
##########
@@ -216,6 +216,25 @@ public Dataflow create(PipelineOptions options) {
 
   void setDumpHeapOnOOM(boolean dumpHeapBeforeExit);
 
+  /**
+   * If true, save a JFR profile when GC thrashing is first detected. The profile will run for the
+   * amount of time set by --jfrRecordingDurationSec, or 60 seconds by default.
+   *
+   * <p>Note, JFR profiles are only supported on java 9 and up.
+   */
+  @Description(
+      "If true, save a JFR profile before killing a thread or process "
+          + "which is GC thrashing or out of memory.  Only available on java 9 or up")
+  boolean getRecordJfrOnGcThrashing();

Review comment:
       heh yeah I mentioned that in my comment, I'll do it in another review once this is accepted/landed.  I didn't want to apply the same changes twice. :P




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org