You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/27 02:49:47 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1535: [CALCITE-3451] Support TableModify in RelMdNodeTypes.

jinxing64 commented on a change in pull request #1535: [CALCITE-3451] Support TableModify in RelMdNodeTypes.
URL: https://github.com/apache/calcite/pull/1535#discussion_r339323159
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
 ##########
 @@ -2350,6 +2351,15 @@ private void checkNodeTypeCount(String sql, Map<Class<? extends RelNode>, Intege
     checkNodeTypeCount(sql, expected);
   }
 
+  @Test public void testNodeTypeTableModify() {
 
 Review comment:
   How about renaming as testNodeTypeCountTableModify ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services