You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/22 21:35:44 UTC
[GitHub] [airflow] simplylizz opened a new pull request #19175: Add migration job resources
simplylizz opened a new pull request #19175:
URL: https://github.com/apache/airflow/pull/19175
Add possibility to set resource limits and requests for airflow-migration-job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734891083
##########
File path: chart/values.schema.json
##########
@@ -1737,6 +1737,23 @@
}
}
},
+ "resources": {
+ "description": "Resources for the migrate database job pod",
+ "type": "object",
Review comment:
We should specify the exact type - `ResourceRequirements`.
Example:
https://github.com/artifacthub/hub/blob/7dc1946d8ce108844121b33930cb2fd2b036c0e8/charts/artifact-hub/values.schema.json#L231-L236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950149606
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-949972723
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] simplylizz commented on pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
simplylizz commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950163769
https://github.com/apache/airflow/runs/3984371457?check_suite_focus=true#step:8:4114 - @mik-laj I see one test is failing after merging. Should I bother with it or they are just flaky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734959805
##########
File path: chart/values.schema.json
##########
@@ -1737,6 +1737,24 @@
}
}
},
+ "resources": {
+ "description": "Resources for the migrate database job pod",
+ "type": "object",
+ "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.19.0/_definitions.json#/definitions/io.k8s.api.core.v1.ResourceRequirements",
Review comment:
See: https://github.com/apache/airflow/blob/d70909422ec7ec2f6e5311d26c1b15e31c3bc188/chart/tests/helm_template_generator.py#L34-L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #19175:
URL: https://github.com/apache/airflow/pull/19175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] simplylizz commented on a change in pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
simplylizz commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734942135
##########
File path: chart/values.schema.json
##########
@@ -1737,6 +1737,23 @@
}
}
},
+ "resources": {
+ "description": "Resources for the migrate database job pod",
+ "type": "object",
Review comment:
```suggestion
"type": "object",
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.19.0/_definitions.json#/definitions/io.k8s.api.core.v1.ResourceRequirements",
```
You mean like this? Sorry, but are you sure? Just want to double check because I don't see even a single mention of `$ref` in this file. Please let me know if it's indeed the case or just click on "commit suggestion".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#issuecomment-950166974
It looks like a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19175: Add migration job resources
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19175:
URL: https://github.com/apache/airflow/pull/19175#discussion_r734959703
##########
File path: chart/values.schema.json
##########
@@ -1737,6 +1737,24 @@
}
}
},
+ "resources": {
+ "description": "Resources for the migrate database job pod",
+ "type": "object",
+ "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.19.0/_definitions.json#/definitions/io.k8s.api.core.v1.ResourceRequirements",
Review comment:
```suggestion
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.ResourceRequirements",
```
We support a newer version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org