You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/05/20 12:52:46 UTC
[PR] Test Duration in `fuzz` tests [datafusion]
alamb opened a new pull request, #16111:
URL: https://github.com/apache/datafusion/pull/16111
## Which issue does this PR close?
- Related to https://github.com/apache/datafusion/pull/15748
## Rationale for this change
I noticed there was no coverage for Duration in the aggregation fuzz tests
## What changes are included in this PR?
Add support for Durations
## Are these changes tested?
Yes, in CI
## Are there any user-facing changes?
No, test only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16111:
URL: https://github.com/apache/datafusion/pull/16111#issuecomment-2897830636
Thank you @zhuqi-lucas and @2010YOUY01 for the reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #16111:
URL: https://github.com/apache/datafusion/pull/16111#discussion_r2097915073
##########
test-utils/src/array_gen/random_data.rs:
##########
@@ -100,6 +106,15 @@ impl RandomNativeData for IntervalMonthDayNanoType {
}
}
+// Restrict Duration(Seconds) to i64::MIN / 1000 to i64::MAX / 1000 to
+// avoid panics on pretty printing. See
+// https://github.com/apache/arrow-rs/issues/7533
Review Comment:
A good doc for it, thanks @alamb .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16111:
URL: https://github.com/apache/datafusion/pull/16111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org