You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/03/15 16:37:43 UTC
[GitHub] [hadoop] steveloughran opened a new pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
steveloughran opened a new pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777
Removes string match so change in AWS S3 error message doesn't cause the test to fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran merged pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran merged pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#issuecomment-805986486
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#issuecomment-800288850
This is ready to be reviewed @mukund-thakur
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#issuecomment-799565413
ran test case against S3 london; all good
```
[INFO] Running org.apache.hadoop.fs.s3a.auth.ITestAssumeRole
[INFO] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 124.066 s - in org.apache.hadoop.fs.s3a.auth.ITestAssumeRole
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#discussion_r595920411
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
##########
@@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception {
conf.set(SECRET_KEY, "not secret");
expectFileSystemCreateFailure(conf,
AWSBadRequestException.class,
- "not a valid " +
- "key=value pair (missing equal-sign) in Authorization header");
+ "IncompleteSignature");
Review comment:
yes. They've changed the string, and rather than try and keep up with whatever error message comes back, I'll just remove the match. We had to do the same with some of the assumed role tests a few releases back when they changed the max life of a role token from 60 minutes to 12h.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
mukund-thakur commented on a change in pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#discussion_r599582337
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
##########
@@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception {
conf.set(SECRET_KEY, "not secret");
expectFileSystemCreateFailure(conf,
AWSBadRequestException.class,
- "not a valid " +
- "key=value pair (missing equal-sign) in Authorization header");
+ "IncompleteSignature");
Review comment:
I though you said you will completely remove the string matching. But we are still trying to match "**IncompleteSignature**"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
mukund-thakur commented on a change in pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#discussion_r595760826
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
##########
@@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception {
conf.set(SECRET_KEY, "not secret");
expectFileSystemCreateFailure(conf,
AWSBadRequestException.class,
- "not a valid " +
- "key=value pair (missing equal-sign) in Authorization header");
+ "IncompleteSignature");
Review comment:
As per the commit message "Removes string match so change in AWS S3 error message doesn't cause the test to fail", the complete string matching is to be removed right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#discussion_r599835557
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java
##########
@@ -255,8 +255,7 @@ public void testAssumeRoleBadInnerAuth() throws Exception {
conf.set(SECRET_KEY, "not secret");
expectFileSystemCreateFailure(conf,
AWSBadRequestException.class,
- "not a valid " +
- "key=value pair (missing equal-sign) in Authorization header");
+ "IncompleteSignature");
Review comment:
sorry, I was confused. it's looking for the structured bit of the error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#issuecomment-804912248
@mukund-thakur any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2777: HADOOP-17476. ITestAssumeRole.testAssumeRoleBadInnerAuth failure.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2777:
URL: https://github.com/apache/hadoop/pull/2777#issuecomment-799621768
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 43s | | trunk passed |
| +1 :green_heart: | compile | 0m 45s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 39s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 0m 30s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 1m 10s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 10s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 34s | | the patch passed |
| +1 :green_heart: | compile | 0m 35s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 35s | | the patch passed |
| +1 :green_heart: | compile | 0m 29s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 0m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 20s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 15s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 1m 8s | | the patch passed |
| +1 :green_heart: | shadedclient | 13m 48s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 56s | | hadoop-aws in the patch passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not generate ASF License warnings. |
| | | 73m 47s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2777/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2777 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux c9b365c9441d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 26dcebefe3bbd4f88a408301c7cd765894befcf6 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2777/1/testReport/ |
| Max. process+thread count | 612 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2777/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org